starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4373] [MERGED] Potential fix/new knowledge for hangig podcasts #4227

New Issue
Closed
opened 2026-04-25 00:18:53 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:53 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4373
Author: @Vito0912
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/4/2025
Merged by: @advplyr

Base: master ← Head: feat/maybeFixPodcast

📝 Commits (2)

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 server/managers/PodcastManager.js (+11 -1)

📄 Description

Brief summary

From the logs, I strongly suspect that the timeout for the feed request never triggers, which causes the code to hang. As a result, it is never removed from the executing list and is not executed again. To check this (since it is possible that the ssrf filter interferes with the timeout), I added a promise that will throw after the timeout to ensure it works. If this works, we will know that it has something to do with axios and can implement a better fix. This change does not affect any behavior and still allows axios to fail correctly (with an extra second), so it should be safe to merge.

Which issue is fixed?

Potentially fixe s https://github.com/advplyr/audiobookshelf/issues/4098

In-depth Description

How have you tested this?

Own podcasts with 1 minute cron and custom timeout values

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4373 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/4/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/maybeFixPodcast` --- ### 📝 Commits (2) - [`9bb4dc3`](https://github.com/advplyr/audiobookshelf/commit/9bb4dc3ab0a00c9d9df26390413f3a52b1071a94) potential fix - [`357176b`](https://github.com/advplyr/audiobookshelf/commit/357176b301551b8c2551b94f41be87c28df3e950) catch timeout ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/PodcastManager.js` (+11 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary From the logs, I strongly suspect that the timeout for the feed request never triggers, which causes the code to hang. As a result, it is never removed from the executing list and is not executed again. To check this (since it is possible that the ssrf filter interferes with the timeout), I added a promise that will throw after the timeout to ensure it works. If this works, we will know that it has something to do with axios and can implement a better fix. This change does not affect any behavior and still allows axios to fail correctly (with an extra second), so it should be safe to merge. ## Which issue is fixed? Potentially fixe s https://github.com/advplyr/audiobookshelf/issues/4098 ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? Own podcasts with 1 minute cron and custom timeout values ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:53 +02:00
adam closed this issue 2026-04-25 00:18:54 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?