starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4302] [CLOSED] Feat/more notifications #4211

New Issue
Closed
opened 2026-04-25 00:18:49 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:49 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4302
Author: @Vito0912
Created: 5/17/2025
Status: ❌ Closed

Base: master ← Head: feat/moreNotifications

📝 Commits (7)

  • 04ba949 first draft
  • 9e28ee0 more notifications
  • 7b62b6b task notifications
  • 39f59e5 moved flatten after O(1)
  • dc41ccc prettier
  • 64fa489 fixed Unit-Test and added void for to async methods
  • 7bafc63 Merge branch 'advplyr:master' into feat/moreNotifications

📊 Changes

5 files changed (+207 additions, -8 deletions)

View changed files

📝 server/SocketAuthority.js (+20 -0)
📝 server/managers/NotificationManager.js (+24 -6)
📝 server/objects/Notification.js (+2 -2)
📝 server/utils/notifications.js (+135 -0)
➕ server/utils/objectUtils.js (+26 -0)

📄 Description

Brief summary

This adds more notification events like user_online or task_finished.

Which issue is fixed?

/

In-depth Description

This uses a set number of emitter events sent by the existing websocket and sends a notification if it is enabled for this notification type. This is currently a DRAFT because examples are missing, and I have not filled all of them yet. Some things also need to be tested and added:

  • user_offline
  • series_added
  • series_updated
  • author_added
  • author_updated
  • user_session_closed
  • user_updated
  • share_open
  • share_closed

It is easy to add, but very time-consuming.

How have you tested this?

Local server with apprise

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4302 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 5/17/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/moreNotifications` --- ### 📝 Commits (7) - [`04ba949`](https://github.com/advplyr/audiobookshelf/commit/04ba9491826fbc2e23b332adb797b7b5ebd3c32f) first draft - [`9e28ee0`](https://github.com/advplyr/audiobookshelf/commit/9e28ee036f9718793a64ecd5aca9722ec61e2574) more notifications - [`7b62b6b`](https://github.com/advplyr/audiobookshelf/commit/7b62b6be86bebb5175d623479740f3b70476fc4c) task notifications - [`39f59e5`](https://github.com/advplyr/audiobookshelf/commit/39f59e518957acd8ff1e0b4583b3bc24f5581d4a) moved flatten after O(1) - [`dc41ccc`](https://github.com/advplyr/audiobookshelf/commit/dc41ccc3770f08e0eb91245ca97720f2c51af188) prettier - [`64fa489`](https://github.com/advplyr/audiobookshelf/commit/64fa48981eb5009938c53f0692940173580d5875) fixed Unit-Test and added void for to async methods - [`7bafc63`](https://github.com/advplyr/audiobookshelf/commit/7bafc63550a8e57b45f913dc5c00407140d46ec6) Merge branch 'advplyr:master' into feat/moreNotifications ### 📊 Changes **5 files changed** (+207 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `server/SocketAuthority.js` (+20 -0) 📝 `server/managers/NotificationManager.js` (+24 -6) 📝 `server/objects/Notification.js` (+2 -2) 📝 `server/utils/notifications.js` (+135 -0) ➕ `server/utils/objectUtils.js` (+26 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature. See https://github.blog/2019-02-14-introducing-draft-pull-requests/ for more details. If you do not follow this template, the PR may be closed without review. Please make sure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This adds more notification events like `user_online` or `task_finished`. ## Which issue is fixed? / ## In-depth Description This uses a set number of emitter events sent by the existing websocket and sends a notification if it is enabled for this notification type. This is currently a DRAFT because examples are missing, and I have not filled all of them yet. Some things also need to be tested and added: - `user_offline` - `series_added` - `series_updated` - `author_added` - `author_updated` - `user_session_closed` - `user_updated` - `share_open` - `share_closed` It is easy to add, but very time-consuming. ## How have you tested this? Local server with apprise ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:49 +02:00
adam closed this issue 2026-04-25 00:18:49 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?