starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4240] [MERGED] Improves Year in Review display logic #4195

New Issue
Closed
opened 2026-04-25 00:18:44 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:44 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4240
Author: @josh-vin
Created: 4/29/2025
Status: ✅ Merged
Merged: 5/1/2025
Merged by: @advplyr

Base: master ← Head: feat/defaultYearInReview

📝 Commits (1)

  • 58cd751 Improves Year in Review display logic

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 client/components/stats/YearInReviewBanner.vue (+5 -4)

📄 Description

Brief summary

Allows users created in the same year to see some stats on the "Year in Review" page.

Which issue is fixed?

I could not find an issue regarding this. I could have maybe created one but just decided to fix it.

In-depth Description

I just started using AudiobookShelf and noticed that the stats page defaults to the previous year. It looks like there is some logic to allow users to select the current year but that is only if they have more than 1 available year.

I opted to keep that logic and only show previous year stats if those stats exist. In December users with more than one year will start to see their current year recap. New users will see previous year by default as soon as they pass into a new year after their account was created.

How have you tested this?

I loaded the page for "Your Stats" with my user createdAt timestamp set with a year in 2025 to verify that it would default to the current year . (First image)

I then modified the DB for my user to have a createdAt timestamp from 2024. My stats page then pulled up with the default of the previous year with a drop down to select 2025. (Second image).

Screenshots

image

image

Before the issue was fixed, this was the behavior for users that did not have any data from last year (they were created in the current year):
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4240 **Author:** [@josh-vin](https://github.com/josh-vin) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 5/1/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/defaultYearInReview` --- ### 📝 Commits (1) - [`58cd751`](https://github.com/advplyr/audiobookshelf/commit/58cd751b43733ac4c53a2eb546224fd9d2ccd595) Improves Year in Review display logic ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `client/components/stats/YearInReviewBanner.vue` (+5 -4) </details> ### 📄 Description ## Brief summary <!-- Please provide a brief summary of what your PR attempts to achieve. --> Allows users created in the same year to see some stats on the "Year in Review" page. ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> I could not find an issue regarding this. I could have maybe created one but just decided to fix it. ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> I just started using AudiobookShelf and noticed that the stats page defaults to the previous year. It looks like there is some logic to allow users to select the current year but that is only if they have more than 1 available year. I opted to keep that logic and only show previous year stats if those stats exist. In December users with more than one year will start to see their current year recap. New users will see previous year by default as soon as they pass into a new year after their account was created. ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> I loaded the page for "Your Stats" with my user createdAt timestamp set with a year in 2025 to verify that it would default to the current year . (First image) I then modified the DB for my user to have a createdAt timestamp from 2024. My stats page then pulled up with the default of the previous year with a drop down to select 2025. (Second image). ## Screenshots ![image](https://github.com/user-attachments/assets/624b7673-6e26-4517-aa8f-6bb15cb9543f) ![image](https://github.com/user-attachments/assets/1d0bf5fa-e779-4578-9466-7d0ae1abba9e) <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> Before the issue was fixed, this was the behavior for users that did not have any data from last year (they were created in the current year): ![image](https://github.com/user-attachments/assets/76bcba17-20bf-46d4-beb5-8f19f93e20de) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:44 +02:00
adam closed this issue 2026-04-25 00:18:44 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?