starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4226] [MERGED] Changes to Chapter-Lookup #4192

New Issue
Closed
opened 2026-04-25 00:18:43 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:43 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4226
Author: @Vito0912
Created: 4/27/2025
Status: ✅ Merged
Merged: 5/10/2025
Merged by: @advplyr

Base: master ← Head: feat/chapterLookUp

📝 Commits (6)

  • a2dc76e remove brading
  • 38957d4 fix shift times not works when editing
  • 65aec6a Adds locale
  • a1074e6 Fixed crash
  • 26c976b Merge branch 'master' into feat/chapterLookUp
  • 0df5a78 Update chapter toast strings, update spacing, autoformat

📊 Changes

2 files changed (+49 additions, -10 deletions)

View changed files

📝 client/pages/audiobook/_id/chapters.vue (+46 -10)
📝 client/strings/en-us.json (+3 -0)

📄 Description

Brief summary

Adds a new checkbox to remove Audible (Intro and Outro) branding, for example, if the book was not obtained from Audible.
Fixes a bug where trying to subtract more time than the first chapter would not work, even after changing the time in the UI, unless you saved and reopened it.
Makes the error message for timeshifting clearer.

Which issue is fixed?

Discord

In-depth Description

This only happens if the checkmark is checked (which is false by default):
Audible does use the branding times. If the checkbox is enabled, I subtract the branding time from all chapters to move them forward. If a chapter is inside the intro (which I have never seen in a book), it will be set to the next available second.
If a chapter is inside the outro, it is removed (because in that case the outro does not exist).

I fixed a bug where, if you tried to add more time than the length of the first chapter and then edited the time of the second chapter to subtract that time, it would still show an error.
The simple fix was to use the second chapter’s start time instead of the first chapter’s end time, since start times are updated on the fly.

I also moved the toast messages to new translation strings. I changed the toast string for the error message, which now better explains how you can subtract more time if you want to.

How have you tested this?

Lookup a few books

Screenshots

grafik

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4226 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 4/27/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/chapterLookUp` --- ### 📝 Commits (6) - [`a2dc76e`](https://github.com/advplyr/audiobookshelf/commit/a2dc76e1902c8664dcfb836a1a13ef5aed38d5ea) remove brading - [`38957d4`](https://github.com/advplyr/audiobookshelf/commit/38957d4f323cceaad92d1751fe2116f426e763f7) fix shift times not works when editing - [`65aec6a`](https://github.com/advplyr/audiobookshelf/commit/65aec6a0993f39481b958e02a81d5382f3d76184) Adds locale - [`a1074e6`](https://github.com/advplyr/audiobookshelf/commit/a1074e69ac2addcfbb4ab3696587326fb2f20285) Fixed crash - [`26c976b`](https://github.com/advplyr/audiobookshelf/commit/26c976b6b9ec12e32a5bd3f1e7d6777e0320488d) Merge branch 'master' into feat/chapterLookUp - [`0df5a78`](https://github.com/advplyr/audiobookshelf/commit/0df5a7816df88d66088c497565037eb254c4a95f) Update chapter toast strings, update spacing, autoformat ### 📊 Changes **2 files changed** (+49 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/chapters.vue` (+46 -10) 📝 `client/strings/en-us.json` (+3 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Adds a new checkbox to remove Audible (Intro and Outro) branding, for example, if the book was not obtained from Audible. Fixes a bug where trying to subtract more time than the first chapter would not work, even after changing the time in the UI, unless you saved and reopened it. Makes the error message for timeshifting clearer. ## Which issue is fixed? Discord ## In-depth Description This only happens if the checkmark is checked (which is false by default): Audible does use the branding times. If the checkbox is enabled, I subtract the branding time from all chapters to move them forward. If a chapter is inside the intro (which I have never seen in a book), it will be set to the next available second. If a chapter is inside the outro, it is removed (because in that case the outro does not exist). --- I fixed a bug where, if you tried to add more time than the length of the first chapter and then edited the time of the second chapter to subtract that time, it would still show an error. The simple fix was to use the second chapter’s start time instead of the first chapter’s end time, since start times are updated on the fly. I also moved the toast messages to new translation strings. I changed the toast string for the error message, which now better explains how you can subtract more time if you want to. ## How have you tested this? Lookup a few books ## Screenshots ![grafik](https://github.com/user-attachments/assets/5d119824-8b89-41df-b356-d161ae66498a) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:43 +02:00
adam closed this issue 2026-04-25 00:18:43 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?