starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4151] [MERGED] Fix broken component tests #4180

New Issue
Closed
opened 2026-04-25 00:18:40 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:40 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4151
Author: @mikiher
Created: 3/23/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @advplyr

Base: master ← Head: fix-component-tests

📝 Commits (2)

  • b18da95 Fix broken component tests
  • 59e099f Add GitHub Actions workflow for running component tests

📊 Changes

4 files changed (+63 additions, -4 deletions)

View changed files

➕ .github/workflows/component-tests.yml (+48 -0)
📝 client/cypress/tests/components/cards/AuthorCard.cy.js (+5 -3)
📝 client/cypress/tests/components/cards/LazyBookCard.cy.js (+2 -1)
📝 client/cypress/tests/components/cards/LazySeriesCard.cy.js (+8 -0)

📄 Description

Brief summary

This fixes some broken client component tests

Which issue is fixed?

No issue.

In-depth Description

Unfortunately, we don't run component tests automatically, so they break from time to time.
This fixes them to run with the current code.

If it's OK with you, I'll add these to the push procedure using a Github workflow (like unit tests).

How have you tested this?

All existing tests run.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4151 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/23/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-component-tests` --- ### 📝 Commits (2) - [`b18da95`](https://github.com/advplyr/audiobookshelf/commit/b18da959dbf4a8727e55f744196ec678d6d70476) Fix broken component tests - [`59e099f`](https://github.com/advplyr/audiobookshelf/commit/59e099f9500b838731d4ea41d3c65320f22a332f) Add GitHub Actions workflow for running component tests ### 📊 Changes **4 files changed** (+63 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/component-tests.yml` (+48 -0) 📝 `client/cypress/tests/components/cards/AuthorCard.cy.js` (+5 -3) 📝 `client/cypress/tests/components/cards/LazyBookCard.cy.js` (+2 -1) 📝 `client/cypress/tests/components/cards/LazySeriesCard.cy.js` (+8 -0) </details> ### 📄 Description ## Brief summary This fixes some broken client component tests ## Which issue is fixed? No issue. ## In-depth Description Unfortunately, we don't run component tests automatically, so they break from time to time. This fixes them to run with the current code. If it's OK with you, I'll add these to the push procedure using a Github workflow (like unit tests). ## How have you tested this? All existing tests run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:40 +02:00
adam closed this issue 2026-04-25 00:18:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4180
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?