starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4037] [MERGED] Route from Issues to Library page after last issue was removed #4155

New Issue
Closed
opened 2026-04-25 00:18:34 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:34 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4037
Author: @mikiher
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @advplyr

Base: master ← Head: route-to-library-if-last-issue-removed

📝 Commits (5)

  • e8b60de Invalidate count cache on entity update
  • 9d7f44f Fix RSS Feed Open query
  • d6b58c2 Revert "Invalidate count cache on entity update"
  • 364ccd8 Use count cache only when no filter is set
  • 6c0e42d Route from Issues to Library if last issue is removed

📊 Changes

3 files changed (+57 additions, -35 deletions)

View changed files

📝 client/components/app/LazyBookshelf.vue (+13 -0)
📝 server/utils/queries/libraryItemsBookFilters.js (+26 -22)
📝 server/utils/queries/libraryItemsPodcastFilters.js (+18 -13)

📄 Description

Brief summary

After the last issue in the Issues page was removed, route to the Library page (no point in showing Issues page with 0 issues)

Which issue is fixed?

Fixes #4022

In-depth Description

When item_removed notification is received from the socket, we add a check - if no items are left and we're on the Issues page, we route to the Library page and reload the filter data.

How have you tested this?

Deleted the last book from the Issues page using Delete from the menu item, and checked that switch to Library page happens and that Issues page disappears from the sidebar.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4037 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `route-to-library-if-last-issue-removed` --- ### 📝 Commits (5) - [`e8b60de`](https://github.com/advplyr/audiobookshelf/commit/e8b60defb6b04fb3654208c5e9365bbdbcfcdbda) Invalidate count cache on entity update - [`9d7f44f`](https://github.com/advplyr/audiobookshelf/commit/9d7f44f73aca6157e7a4be28361c510200494ad1) Fix RSS Feed Open query - [`d6b58c2`](https://github.com/advplyr/audiobookshelf/commit/d6b58c2f10f66c5ef36fc720da2c901657b75021) Revert "Invalidate count cache on entity update" - [`364ccd8`](https://github.com/advplyr/audiobookshelf/commit/364ccd85fe0f9504c66cf7cf332c3534663d50fb) Use count cache only when no filter is set - [`6c0e42d`](https://github.com/advplyr/audiobookshelf/commit/6c0e42db49067e05af263501a9d6d79aa4a95678) Route from Issues to Library if last issue is removed ### 📊 Changes **3 files changed** (+57 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/LazyBookshelf.vue` (+13 -0) 📝 `server/utils/queries/libraryItemsBookFilters.js` (+26 -22) 📝 `server/utils/queries/libraryItemsPodcastFilters.js` (+18 -13) </details> ### 📄 Description ## Brief summary After the last issue in the Issues page was removed, route to the Library page (no point in showing Issues page with 0 issues) ## Which issue is fixed? Fixes #4022 ## In-depth Description When `item_removed` notification is received from the socket, we add a check - if no items are left and we're on the Issues page, we route to the Library page and reload the filter data. ## How have you tested this? Deleted the last book from the Issues page using `Delete` from the menu item, and checked that switch to Library page happens and that Issues page disappears from the sidebar. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:34 +02:00
adam closed this issue 2026-04-25 00:18:34 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?