starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4010] [CLOSED] Fix all date constructors to Date(0) to prevent test flakiness #4144

New Issue
Closed
opened 2026-04-25 00:18:32 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:32 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4010
Author: @mikiher
Created: 2/20/2025
Status: ❌ Closed

Base: master ← Head: fix-flaky-v.2.15.0-test

📝 Commits (1)

  • 741ae22 Fix all date constructors to Date(0) to prevent test flakiness

📊 Changes

1 file changed (+14 additions, -14 deletions)

View changed files

📝 test/server/migrations/v2.15.0-series-column-unique.test.js (+14 -14)

📄 Description

Brief summary

Fix Date constructors to Date(0) to provide stable dates and prevent test flakiness

Which issue is fixed?

No issue.

In-depth Description

Using just Date() caused the test input to be unstable, and caused sporadic test failures.

How have you tested this?

Ran the test to make sure it still passes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4010 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 2/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-flaky-v.2.15.0-test` --- ### 📝 Commits (1) - [`741ae22`](https://github.com/advplyr/audiobookshelf/commit/741ae2216a2d48ccf33a413eb170be4d95323bc6) Fix all date constructors to Date(0) to prevent test flakiness ### 📊 Changes **1 file changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `test/server/migrations/v2.15.0-series-column-unique.test.js` (+14 -14) </details> ### 📄 Description ## Brief summary Fix Date constructors to Date(0) to provide stable dates and prevent test flakiness ## Which issue is fixed? No issue. ## In-depth Description Using just Date() caused the test input to be unstable, and caused sporadic test failures. ## How have you tested this? Ran the test to make sure it still passes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:32 +02:00
adam closed this issue 2026-04-25 00:18:32 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4144
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?