starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3984] [MERGED] Fix chapter end sleep timer sometimes not stopping #3969 #4140

New Issue
Closed
opened 2026-04-25 00:18:28 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:28 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3984
Author: @advplyr
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/14/2025
Merged by: @advplyr

Base: master ← Head: fix-chapter-end-sleep-timer

📝 Commits (1)

  • c4d99a1 Fix chapter end sleep timer sometimes not stopping #3969

📊 Changes

1 file changed (+12 additions, -7 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+12 -7)

📄 Description

Brief summary

End of chapter sleep timer implemented in #2059 has an issue where the chapter can switch between function calls to checkChapterEnd.
It is easiest to test this bug by increasing the playback speed

Which issue is fixed?

Fixes #3969

In-depth Description

This is solved by storing the last chapter id and comparing the current chapter with the last. If they changed then stop the timer.

The difference from the previous implementation will be that if you change chapters while the EoC sleep timer is activated then it will end the sleep timer. I think that is normal

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3984 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/14/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-chapter-end-sleep-timer` --- ### 📝 Commits (1) - [`c4d99a1`](https://github.com/advplyr/audiobookshelf/commit/c4d99a118fc0ebd613bf58dd73324a4776e942f8) Fix chapter end sleep timer sometimes not stopping #3969 ### 📊 Changes **1 file changed** (+12 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+12 -7) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary End of chapter sleep timer implemented in #2059 has an issue where the chapter can switch between function calls to `checkChapterEnd`. It is easiest to test this bug by increasing the playback speed ## Which issue is fixed? Fixes #3969 ## In-depth Description This is solved by storing the last chapter id and comparing the current chapter with the last. If they changed then stop the timer. The difference from the previous implementation will be that if you change chapters while the EoC sleep timer is activated then it will end the sleep timer. I think that is normal --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:28 +02:00
adam closed this issue 2026-04-25 00:18:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?