starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3985] [MERGED] Fix server crash when quick match all updates series sequence #3961 #4139

New Issue
Closed
opened 2026-04-25 00:18:28 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:28 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3985
Author: @advplyr
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @advplyr

Base: master ← Head: fix-quick-match-all-crash

📝 Commits (1)

  • d9b206f Fix server crash when quick match all updates existing series sequence #3961

📊 Changes

2 files changed (+1 additions, -7 deletions)

View changed files

📝 server/models/LibraryItem.js (+1 -1)
📝 server/scanner/Scanner.js (+0 -6)

📄 Description

Brief summary

When using the library option quick match all the server will crash if it detects an existing series sequence needs to be updated.

Which issue is fixed?

Fixes #3961

In-depth Description

To reproduce this:

  1. Find a book that quick matches with a series and sequence.
  2. Change the series sequence number
  3. Trigger quick match all in the more menu dropdown of the library

The issue is when querying for the library items the id of the bookSeries isn't being pulled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3985 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-quick-match-all-crash` --- ### 📝 Commits (1) - [`d9b206f`](https://github.com/advplyr/audiobookshelf/commit/d9b206fe1cfdd6f6714917d68e4b1bf726e968b9) Fix server crash when quick match all updates existing series sequence #3961 ### 📊 Changes **2 files changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/models/LibraryItem.js` (+1 -1) 📝 `server/scanner/Scanner.js` (+0 -6) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary When using the library option quick match all the server will crash if it detects an existing series sequence needs to be updated. ## Which issue is fixed? Fixes #3961 ## In-depth Description To reproduce this: 1. Find a book that quick matches with a series and sequence. 2. Change the series sequence number 3. Trigger quick match all in the more menu dropdown of the library The issue is when querying for the library items the `id` of the `bookSeries` isn't being pulled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:28 +02:00
adam closed this issue 2026-04-25 00:18:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?