starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3954] [MERGED] Fix next/prev buttons on edit modals not changing description when focused #4130

New Issue
Closed
opened 2026-04-25 00:18:26 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:26 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3954
Author: @advplyr
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @advplyr

Base: master ← Head: fix_next_prev_edit_description

📝 Commits (2)

  • 0dd57a8 Fix using next/prev in edit modals while rich text input is focused #3951
  • 36ef675 Fix edit episode next/prev buttons showing when editing from home page

📊 Changes

4 files changed (+17 additions, -1 deletions)

View changed files

📝 client/components/app/BookShelfRow.vue (+1 -0)
📝 client/components/modals/item/EditModal.vue (+7 -1)
📝 client/components/modals/podcast/EditEpisode.vue (+8 -0)
📝 client/components/widgets/ItemSlider.vue (+1 -0)

📄 Description

Brief summary

This fixes 2 issues.

  1. [PR #3367] [CLOSED] Fix: root user cannot be edited (#3951)
  2. Next/prev buttons are showing when editing episodes on the home page when they shouldn't be (reproducible steps below)

Which issue is fixed?

Fixes #3951

In-depth Description

To reproduce 2 above:

  1. Navigate to a podcast page that has multiple episodes
  2. Press edit for a episode and notice the next/prev buttons work correctly.
  3. Close the modal and navigate to the home page.
  4. Press edit on an episode card and notice the next/prev buttons show but when pressed throw an error.

The reason is because the episodes from the podcast page are not being cleared and the home page doesn't support the next/prev buttons.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3954 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix_next_prev_edit_description` --- ### 📝 Commits (2) - [`0dd57a8`](https://github.com/advplyr/audiobookshelf/commit/0dd57a8912143c00fc1943f007a3c654466e6487) Fix using next/prev in edit modals while rich text input is focused #3951 - [`36ef675`](https://github.com/advplyr/audiobookshelf/commit/36ef675556461d9cd1bdb70e43be7289afded7fa) Fix edit episode next/prev buttons showing when editing from home page ### 📊 Changes **4 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/BookShelfRow.vue` (+1 -0) 📝 `client/components/modals/item/EditModal.vue` (+7 -1) 📝 `client/components/modals/podcast/EditEpisode.vue` (+8 -0) 📝 `client/components/widgets/ItemSlider.vue` (+1 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This fixes 2 issues. 1. #3951 2. Next/prev buttons are showing when editing episodes on the home page when they shouldn't be (reproducible steps below) ## Which issue is fixed? Fixes #3951 ## In-depth Description To reproduce 2 above: 1. Navigate to a podcast page that has multiple episodes 2. Press edit for a episode and notice the next/prev buttons work correctly. 3. Close the modal and navigate to the home page. 4. Press edit on an episode card and notice the next/prev buttons show but when pressed throw an error. The reason is because the episodes from the podcast page are not being cleared and the home page doesn't support the next/prev buttons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:26 +02:00
adam closed this issue 2026-04-25 00:18:26 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?