starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3898] [MERGED] Add bookSeries id attribute to findAllExpandedWhere #4113

New Issue
Closed
opened 2026-04-25 00:18:22 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:22 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3898
Author: @mikiher
Created: 1/26/2025
Status: ✅ Merged
Merged: 1/26/2025
Merged by: @advplyr

Base: master ← Head: fix-batch-quick-match

📝 Commits (1)

  • 9b4732c Add bookSeries id attribute to findAllExpandedWhere

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/models/LibraryItem.js (+1 -1)

📄 Description

Brief summary

Adds bookSeries.id attribute to the sequelize query in LibraryItem.findAllExpandedWhere.

Which issue is fixed?

Fixes #3883

In-depth Description

The bookSeries id is required for the bookSeries.destroy() call here, without it, the destory() call throws an exception since it doesn't have the id in order to construct the deletion query.

Note: this only happens in batch quick match, which calls findAllExpandedWhere()

How have you tested this?

Batch quick match which crashed the server before now completes successfuly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3898 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 1/26/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-batch-quick-match` --- ### 📝 Commits (1) - [`9b4732c`](https://github.com/advplyr/audiobookshelf/commit/9b4732c207c092711137afb13477181d9cac7b1a) Add bookSeries id attribute to findAllExpandedWhere ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/models/LibraryItem.js` (+1 -1) </details> ### 📄 Description ## Brief summary Adds `bookSeries.id` attribute to the sequelize query in `LibraryItem.findAllExpandedWhere`. ## Which issue is fixed? Fixes #3883 ## In-depth Description The bookSeries id is required for the `bookSeries.destroy()` call [here](https://github.com/advplyr/audiobookshelf/blob/e096da1b4d0dfeab02f7a6702cf56237e12e04e8/server/scanner/Scanner.js#L338), without it, the `destory()` call throws an exception since it doesn't have the id in order to construct the deletion query. _Note_: this only happens in batch quick match, which calls `findAllExpandedWhere()` ## How have you tested this? Batch quick match which crashed the server before now completes successfuly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:22 +02:00
adam closed this issue 2026-04-25 00:18:22 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?