starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3867] [MERGED] Updates to generated RSS feed & Fix series/collection feeds #4104

New Issue
Closed
opened 2026-04-25 00:18:20 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:20 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3867
Author: @advplyr
Created: 1/20/2025
Status: ✅ Merged
Merged: 1/20/2025
Merged by: @advplyr

Base: master ← Head: feed_generator_updates

📝 Commits (3)

  • 54a4b09 Update RSS feed to exclude empty tags, format duration, use CDATA
  • a8b9281 Update feed episode description to use CDATA
  • b816c0e Fix opening feed for series and collections

📊 Changes

3 files changed (+57 additions, -34 deletions)

View changed files

📝 server/models/Feed.js (+37 -21)
📝 server/models/FeedEpisode.js (+19 -12)
📝 server/utils/index.js (+1 -1)

📄 Description

Brief summary

A few adjustments to fix/improve the generated RSS feed.
Series & collection feeds were broken due to the getTrackList request returning an empty array.

Which issue is fixed?

Fixes #3866
Although these are likely not the actual issue the user is having in that issue it points to some things this PR addresses.

In-depth Description

The following updates were made:

  1. Feeds no longer include empty tags. For example, previously an empty season would include <itunes:season/>.
  2. itunes:summary value is wrapped in <![CDATA[ .... ]]> because podcast episode descriptions include HTML
  3. itunes:description value is an integer of seconds
  4. Removed unnecessary podlove namespace
  5. Fixes an issue with series and collection feeds where the episode list is empty

How have you tested this?

Tested opening feeds of all variety

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3867 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/20/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feed_generator_updates` --- ### 📝 Commits (3) - [`54a4b09`](https://github.com/advplyr/audiobookshelf/commit/54a4b09592eef315d938c6ad384463f0d36fc0ad) Update RSS feed to exclude empty tags, format duration, use CDATA - [`a8b9281`](https://github.com/advplyr/audiobookshelf/commit/a8b92819d1fcc70ae47cd54ec028310835a1cd0f) Update feed episode description to use CDATA - [`b816c0e`](https://github.com/advplyr/audiobookshelf/commit/b816c0e7c439532d069589f3cf675b9822776b08) Fix opening feed for series and collections ### 📊 Changes **3 files changed** (+57 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `server/models/Feed.js` (+37 -21) 📝 `server/models/FeedEpisode.js` (+19 -12) 📝 `server/utils/index.js` (+1 -1) </details> ### 📄 Description ## Brief summary A few adjustments to fix/improve the generated RSS feed. Series & collection feeds were broken due to the `getTrackList` request returning an empty array. ## Which issue is fixed? Fixes #3866 Although these are likely not the actual issue the user is having in that issue it points to some things this PR addresses. ## In-depth Description The following updates were made: 1. Feeds no longer include empty tags. For example, previously an empty season would include `<itunes:season/>`. 2. `itunes:summary` value is wrapped in `<![CDATA[ .... ]]>` because podcast episode descriptions include HTML 3. `itunes:description` value is an integer of seconds 4. Removed unnecessary podlove namespace 5. Fixes an issue with series and collection feeds where the episode list is empty ## How have you tested this? Tested opening feeds of all variety --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:20 +02:00
adam closed this issue 2026-04-25 00:18:20 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?