starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3847] [MERGED] Bookmark modal updates #4101

New Issue
Closed
opened 2026-04-25 00:18:19 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:19 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3847
Author: @advplyr
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @advplyr

Base: master ← Head: bookmark-modal-updates

📝 Commits (2)

  • 2463c62 Update bookmark modal scrollable with create always visible, make UI consistent, hide create when bookmark already exists
  • 32b886a Update bookmark modal to scale with playback rate #3728

📊 Changes

30 files changed (+35 additions, -61 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+1 -1)
📝 client/components/modals/BookmarksModal.vue (+16 -25)
📝 client/components/modals/bookmarks/BookmarkItem.vue (+17 -8)
📝 client/pages/item/_id/index.vue (+1 -1)
📝 client/strings/bg.json (+0 -1)
📝 client/strings/bn.json (+0 -1)
📝 client/strings/ca.json (+0 -1)
📝 client/strings/cs.json (+0 -1)
📝 client/strings/da.json (+0 -1)
📝 client/strings/de.json (+0 -1)
📝 client/strings/en-us.json (+0 -1)
📝 client/strings/es.json (+0 -1)
📝 client/strings/et.json (+0 -1)
📝 client/strings/fr.json (+0 -1)
📝 client/strings/he.json (+0 -1)
📝 client/strings/hr.json (+0 -1)
📝 client/strings/hu.json (+0 -1)
📝 client/strings/it.json (+0 -1)
📝 client/strings/lt.json (+0 -1)
📝 client/strings/nl.json (+0 -1)

...and 10 more files

📄 Description

Brief summary

  1. Update timestamps to scale with playback rate.
  2. Update UI colors to be consistent with other modals.
  3. Update create input to be outside of scrollable container so it is always visible.
  4. Editing bookmark no longer closes modal
  5. Removed edit bookmark success toast

Which issue is fixed?

Fixed #3728

Screenshots

Old:
image

New:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3847 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `bookmark-modal-updates` --- ### 📝 Commits (2) - [`2463c62`](https://github.com/advplyr/audiobookshelf/commit/2463c62bbf1f8acf0db0e9a3e2d82fe2725218f4) Update bookmark modal scrollable with create always visible, make UI consistent, hide create when bookmark already exists - [`32b886a`](https://github.com/advplyr/audiobookshelf/commit/32b886a0c3cda88b56f815deef5ce58dd68b1154) Update bookmark modal to scale with playback rate #3728 ### 📊 Changes **30 files changed** (+35 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+1 -1) 📝 `client/components/modals/BookmarksModal.vue` (+16 -25) 📝 `client/components/modals/bookmarks/BookmarkItem.vue` (+17 -8) 📝 `client/pages/item/_id/index.vue` (+1 -1) 📝 `client/strings/bg.json` (+0 -1) 📝 `client/strings/bn.json` (+0 -1) 📝 `client/strings/ca.json` (+0 -1) 📝 `client/strings/cs.json` (+0 -1) 📝 `client/strings/da.json` (+0 -1) 📝 `client/strings/de.json` (+0 -1) 📝 `client/strings/en-us.json` (+0 -1) 📝 `client/strings/es.json` (+0 -1) 📝 `client/strings/et.json` (+0 -1) 📝 `client/strings/fr.json` (+0 -1) 📝 `client/strings/he.json` (+0 -1) 📝 `client/strings/hr.json` (+0 -1) 📝 `client/strings/hu.json` (+0 -1) 📝 `client/strings/it.json` (+0 -1) 📝 `client/strings/lt.json` (+0 -1) 📝 `client/strings/nl.json` (+0 -1) _...and 10 more files_ </details> ### 📄 Description ## Brief summary 1. Update timestamps to scale with playback rate. 2. Update UI colors to be consistent with other modals. 3. Update create input to be outside of scrollable container so it is always visible. 4. Editing bookmark no longer closes modal 5. Removed edit bookmark success toast ## Which issue is fixed? Fixed #3728 ## Screenshots Old: ![image](https://github.com/user-attachments/assets/b29657c7-c209-4898-8286-bbaa517109dd) New: ![image](https://github.com/user-attachments/assets/6f1baad0-0583-40e4-aa09-7d16bd930686) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:19 +02:00
adam closed this issue 2026-04-25 00:18:19 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?