starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3810] [MERGED] Enable subdirectory support by default #4095

New Issue
Closed
opened 2026-04-25 00:18:17 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:17 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3810
Author: @mikiher
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/19/2025
Merged by: @advplyr

Base: master ← Head: enable-subdirectory

📝 Commits (1)

  • 9668b49 Enable subdirectory support

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 client/nuxt.config.js (+1 -1)
📝 index.js (+1 -1)
📝 prod.js (+1 -1)

📄 Description

Brief summary

Switch to enabling subdirectory support with /audiobookshelf on the server and web client, according to the plan laid out in discussion #3535.

Which issue is fixed?

This finally fixes #385

Users will now be able to set their reverse proxies to proxy /audiobookshelf subdirectory requests

In-depth Description

This is the last step in supporting subdirectory with the existing static site generation approach.

The plan is described in detail in #3535.

As a reminder, this will set a fixed subdirectory of /audiobookshelf on the web client (non-subdirectory paths will get rewritten by the server), and the server will support both subdirectory requests (with /audiobookshelf prefix) and non-subdirectory requests (with no prefix).

Note: Mobile app support for subdirectory is already implemented and checked in with audiobookshelf-app PR #1417, but is pending release of a new version. Other mobile clients that would like to support subdirectory access will likely need to make some changes in the spirit of that PR.

How have you tested this?

This PR just switches the feature on by default.

The many changes required to make this happen were previously tested in respective previous PRs, and were tested again to make sure they still worked now.

One thing I haven't tested properly is the reverse proxy part, since my reverse proxy (on my Synology NAS) doesn't support support subdirectory proxying. I am sure this works well once you set it up on a supporting reverse proxy (like NGINX), but haven't tested this myself.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3810 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `enable-subdirectory` --- ### 📝 Commits (1) - [`9668b49`](https://github.com/advplyr/audiobookshelf/commit/9668b49df95454f19081942e7481afd7451a14e4) Enable subdirectory support ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/nuxt.config.js` (+1 -1) 📝 `index.js` (+1 -1) 📝 `prod.js` (+1 -1) </details> ### 📄 Description ## Brief summary Switch to enabling subdirectory support with `/audiobookshelf` on the server and web client, according to the plan laid out in discussion #3535. ## Which issue is fixed? This finally fixes #385 Users will now be able to set their reverse proxies to proxy `/audiobookshelf` subdirectory requests ## In-depth Description This is the last step in supporting subdirectory with the existing static site generation approach. The plan is described in detail in #3535. As a reminder, this will set a fixed subdirectory of `/audiobookshelf` on the web client (non-subdirectory paths will get rewritten by the server), and the server will support both subdirectory requests (with `/audiobookshelf` prefix) and non-subdirectory requests (with no prefix). _Note_: Mobile app support for subdirectory is already implemented and checked in with audiobookshelf-app PR [#1417](https://github.com/advplyr/audiobookshelf-app/pull/1417), but is pending release of a new version. Other mobile clients that would like to support subdirectory access **will likely need to make some changes** in the spirit of that PR. ## How have you tested this? This PR just switches the feature on by default. The many changes required to make this happen were previously tested in respective previous PRs, and were tested again to make sure they still worked now. One thing I haven't tested properly is the reverse proxy part, since my reverse proxy (on my Synology NAS) doesn't support support subdirectory proxying. I am sure this works well once you set it up on a supporting reverse proxy (like NGINX), but haven't tested this myself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:17 +02:00
adam closed this issue 2026-04-25 00:18:18 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4095
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?