starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3816] [MERGED] Fix Trix to use paragraphs and break on return #4094

New Issue
Closed
opened 2026-04-25 00:18:17 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:17 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3816
Author: @mikiher
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @advplyr

Base: master ← Head: fix-trix-issues

📝 Commits (1)

  • b0dbccd Fix Trix to use paragraphs and break on return

📊 Changes

1 file changed (+23 additions, -1 deletions)

View changed files

📝 client/components/ui/VueTrix.vue (+23 -1)

📄 Description

Brief summary

This fixes a couple of issues with the Trix text editor

In-depth Description

  • Trix translates p tags to div by default, and inserts redundant br tags on paragraph breaks. This fixes this.
  • Trix by default always puts a br tag on Enter, and never breaks a paragraph (there's literally no way to start a new paragraph). This changes the behavior to break paragraphs on Enter (you can still use Shfit+Enter for line breaks, like in other normal editors)

How have you tested this?

This was tested on various podcast episode descriptions in the Episode Details tab.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3816 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-trix-issues` --- ### 📝 Commits (1) - [`b0dbccd`](https://github.com/advplyr/audiobookshelf/commit/b0dbccd283a8e17f23bd627209b9a0de5a167295) Fix Trix to use paragraphs and break on return ### 📊 Changes **1 file changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/components/ui/VueTrix.vue` (+23 -1) </details> ### 📄 Description ## Brief summary This fixes a couple of issues with the Trix text editor ## In-depth Description - Trix translates `p` tags to `div` by default, and inserts redundant `br` tags on paragraph breaks. This fixes this. - Trix by default always puts a `br` tag on Enter, and never breaks a paragraph (there's literally no way to start a new paragraph). This changes the behavior to break paragraphs on Enter (you can still use Shfit+Enter for line breaks, like in other normal editors) ## How have you tested this? This was tested on various podcast episode descriptions in the Episode Details tab. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:17 +02:00
adam closed this issue 2026-04-25 00:18:17 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4094
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?