starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3822] [MERGED] Episode table refresh fixes #4093

New Issue
Closed
opened 2026-04-25 00:18:17 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:17 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3822
Author: @mikiher
Created: 1/11/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @advplyr

Base: master ← Head: episode-table-refresh-fix

📝 Commits (2)

  • 5e2282e Fix LazyEpisodeTable.init to respect non-zero scrollTop
  • de5bc63 Remove deleted episode from returned libraryItem object

📊 Changes

2 files changed (+19 additions, -5 deletions)

View changed files

📝 client/components/tables/podcast/LazyEpisodesTable.vue (+16 -5)
📝 server/controllers/PodcastController.js (+3 -0)

📄 Description

Brief summary

This fixes a couple of issues in LazyEpisodeTable:

  • When an episode is updated, the refresh doesn't account for the current scroll position
  • When an episode is removed, it is not reflected in the table (a zombie episode remains)

Which issue is fixed?

There is no open issue for these (came up over discord discussion).

In-depth Description

There were two bugs fixed:

  • On the client, when a podcast episode is updated, the LazyEpisodeTable.refresh() was called, but it always mounted the first few episodes in the table, with no regard for the current scroll position.
  • On the server, when a podcast episode was removed, the episode was not removed from the libraryItem object return to the client, so a zombie episode was shown after the update.

How have you tested this?

Updated, added and removed podcast episodes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3822 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/11/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `episode-table-refresh-fix` --- ### 📝 Commits (2) - [`5e2282e`](https://github.com/advplyr/audiobookshelf/commit/5e2282ef760a44e9fab3ae6d26cddb0ffba6c967) Fix LazyEpisodeTable.init to respect non-zero scrollTop - [`de5bc63`](https://github.com/advplyr/audiobookshelf/commit/de5bc63d880d4236aaf09f8a0a9b7a876bcee111) Remove deleted episode from returned libraryItem object ### 📊 Changes **2 files changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `client/components/tables/podcast/LazyEpisodesTable.vue` (+16 -5) 📝 `server/controllers/PodcastController.js` (+3 -0) </details> ### 📄 Description ## Brief summary This fixes a couple of issues in LazyEpisodeTable: - When an episode is updated, the refresh doesn't account for the current scroll position - When an episode is removed, it is not reflected in the table (a zombie episode remains) ## Which issue is fixed? There is no open issue for these (came up over discord discussion). ## In-depth Description There were two bugs fixed: - On the client, when a podcast episode is updated, the `LazyEpisodeTable.refresh()` was called, but it always mounted the first few episodes in the table, with no regard for the current scroll position. - On the server, when a podcast episode was removed, the episode was not removed from the libraryItem object return to the client, so a zombie episode was shown after the update. ## How have you tested this? Updated, added and removed podcast episodes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:17 +02:00
adam closed this issue 2026-04-25 00:18:17 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?