starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3794] [MERGED] Fix ffmpeg.addOption for transcoding #4087

New Issue
Closed
opened 2026-04-25 00:18:15 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:15 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3794
Author: @mikiher
Created: 1/4/2025
Status: ✅ Merged
Merged: 1/4/2025
Merged by: @advplyr

Base: master ← Head: fix-stream-ffmpeg-add-option

📝 Commits (1)

  • 43d8d9b Fix ffmpeg.addOption for transcoding

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 server/objects/Stream.js (+4 -4)

📄 Description

Brief summary

Fixes wrong usage of ffmpeg.addOption in Stream.js.

Which issue is fixed?

Fixes #3793

In-depth Description

See my comment on the bug.

How have you tested this?

Used a metadata directory with spaces in it.
Played a book that requires transcoding in iOS/Safari.
This previously failed and now it plays correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3794 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/4/2025 **Status:** ✅ Merged **Merged:** 1/4/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-stream-ffmpeg-add-option` --- ### 📝 Commits (1) - [`43d8d9b`](https://github.com/advplyr/audiobookshelf/commit/43d8d9b286223d8cfdca895adc56c3d09469430e) Fix ffmpeg.addOption for transcoding ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/Stream.js` (+4 -4) </details> ### 📄 Description ## Brief summary Fixes wrong usage of `ffmpeg.addOption` in `Stream.js`. ## Which issue is fixed? Fixes #3793 ## In-depth Description See [my comment](https://github.com/advplyr/audiobookshelf/issues/3793#issuecomment-2571368333) on the bug. ## How have you tested this? Used a metadata directory with spaces in it. Played a book that requires transcoding in iOS/Safari. This previously failed and now it plays correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:15 +02:00
adam closed this issue 2026-04-25 00:18:15 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4087
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?