starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3761] [MERGED] Remove old Collection object + remove unnecessary toasts #4071

New Issue
Closed
opened 2026-04-25 00:18:12 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:12 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3761
Author: @advplyr
Created: 12/30/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @advplyr

Base: master ← Head: remove_old_collection_object

📝 Commits (2)

  • 476933a Refactor Collection model/controller to not use old Collection object, remove
  • 88a0e75 Remove collection add/create modal toasts

📊 Changes

33 files changed (+121 additions, -358 deletions)

View changed files

📝 client/components/modals/collections/AddCreateModal.vue (+1 -6)
📝 client/strings/bg.json (+0 -1)
📝 client/strings/bn.json (+0 -2)
📝 client/strings/ca.json (+0 -2)
📝 client/strings/cs.json (+0 -1)
📝 client/strings/da.json (+0 -1)
📝 client/strings/de.json (+0 -2)
📝 client/strings/en-us.json (+0 -2)
📝 client/strings/es.json (+0 -2)
📝 client/strings/et.json (+0 -1)
📝 client/strings/fr.json (+0 -2)
📝 client/strings/he.json (+0 -1)
📝 client/strings/hr.json (+0 -2)
📝 client/strings/hu.json (+0 -1)
📝 client/strings/it.json (+0 -2)
📝 client/strings/lt.json (+0 -2)
📝 client/strings/nl.json (+0 -2)
📝 client/strings/no.json (+0 -2)
📝 client/strings/pl.json (+0 -1)
📝 client/strings/pt-br.json (+0 -1)

...and 13 more files

📄 Description

Refactors the Collection model and CollectionController to not use the old Collection object in order to remove it.

Similar to https://github.com/advplyr/audiobookshelf/pull/3721 where Feeds were refactored

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3761 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 12/30/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `remove_old_collection_object` --- ### 📝 Commits (2) - [`476933a`](https://github.com/advplyr/audiobookshelf/commit/476933a144f5c1038cda742f71f96bd1694d9d6d) Refactor Collection model/controller to not use old Collection object, remove - [`88a0e75`](https://github.com/advplyr/audiobookshelf/commit/88a0e75576902f25635784328693591f2f7149af) Remove collection add/create modal toasts ### 📊 Changes **33 files changed** (+121 additions, -358 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/collections/AddCreateModal.vue` (+1 -6) 📝 `client/strings/bg.json` (+0 -1) 📝 `client/strings/bn.json` (+0 -2) 📝 `client/strings/ca.json` (+0 -2) 📝 `client/strings/cs.json` (+0 -1) 📝 `client/strings/da.json` (+0 -1) 📝 `client/strings/de.json` (+0 -2) 📝 `client/strings/en-us.json` (+0 -2) 📝 `client/strings/es.json` (+0 -2) 📝 `client/strings/et.json` (+0 -1) 📝 `client/strings/fr.json` (+0 -2) 📝 `client/strings/he.json` (+0 -1) 📝 `client/strings/hr.json` (+0 -2) 📝 `client/strings/hu.json` (+0 -1) 📝 `client/strings/it.json` (+0 -2) 📝 `client/strings/lt.json` (+0 -2) 📝 `client/strings/nl.json` (+0 -2) 📝 `client/strings/no.json` (+0 -2) 📝 `client/strings/pl.json` (+0 -1) 📝 `client/strings/pt-br.json` (+0 -1) _...and 13 more files_ </details> ### 📄 Description Refactors the Collection model and CollectionController to not use the old Collection object in order to remove it. Similar to https://github.com/advplyr/audiobookshelf/pull/3721 where Feeds were refactored --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:12 +02:00
adam closed this issue 2026-04-25 00:18:12 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?