starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3754] [MERGED] Experimental proxy support by manually following redirects #4070

New Issue
Closed
opened 2026-04-25 00:18:12 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:12 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3754
Author: @maxlajoie99
Created: 12/28/2024
Status: ✅ Merged
Merged: 1/1/2025
Merged by: @advplyr

Base: master ← Head: feature/experimental-proxy-support

📝 Commits (2)

  • d7830f4 Experimental proxy support by manually following redirects
  • f3918a4 Auto formatting

📊 Changes

1 file changed (+21 additions, -1 deletions)

View changed files

📝 server/Server.js (+21 -1)

📄 Description

Brief summary

Make downloading podcast episodes work when HTTP_PROXY/HTTPS_PROXY environment variable are present.

Which issue is fixed?

#1313

In-depth Description

Mannually following redirects seems to fix the bug in axios when using a proxy. It is merely a workaround while we wait to upgrade axios / replace pkg like mentionned here.

How have you tested this?

Ran a forward proxy locally using docker, and added both HTTP_PROXY and HTTPS_PROXY to the start command. Then, I searched and downloaded a few podcast episodes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3754 **Author:** [@maxlajoie99](https://github.com/maxlajoie99) **Created:** 12/28/2024 **Status:** ✅ Merged **Merged:** 1/1/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feature/experimental-proxy-support` --- ### 📝 Commits (2) - [`d7830f4`](https://github.com/advplyr/audiobookshelf/commit/d7830f4bfc79cb0dbd7c507263813a8e19083a41) Experimental proxy support by manually following redirects - [`f3918a4`](https://github.com/advplyr/audiobookshelf/commit/f3918a47e14160ce02c79364cc8c04d10023b8c0) Auto formatting ### 📊 Changes **1 file changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/Server.js` (+21 -1) </details> ### 📄 Description ## Brief summary Make downloading podcast episodes work when `HTTP_PROXY`/`HTTPS_PROXY` environment variable are present. ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> #1313 ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> Mannually following redirects seems to fix the bug in axios when using a proxy. It is merely a workaround while we wait to upgrade axios / replace pkg like mentionned [here](https://github.com/advplyr/audiobookshelf/pull/2666#issuecomment-1974083316). ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> Ran a forward proxy locally using docker, and added both `HTTP_PROXY` and `HTTPS_PROXY` to the start command. Then, I searched and downloaded a few podcast episodes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:12 +02:00
adam closed this issue 2026-04-25 00:18:12 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4070
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?