starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3751] [MERGED] Change: height of RSS feed preview to match aspect ratio #4069

New Issue
Closed
opened 2026-04-25 00:18:12 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:12 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3751
Author: @nichwall
Created: 12/27/2024
Status: ✅ Merged
Merged: 12/28/2024
Merged by: @advplyr

Base: master ← Head: rss_feed_image_fix

📝 Commits (1)

  • f46b5a5 Change: height of RSS feed preview to match aspect ratio

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 client/pages/config/rss-feeds.vue (+1 -1)

📄 Description

Brief summary

This PR forces the height of the image preview in the RSS feed to be square and match the size of the width.

Which issue is fixed?

This should fix https://github.com/advplyr/audiobookshelf/issues/3748

In-depth Description

This PR replaces the h-full with h-auto. I did play with changing this to be a div to force the images to be square, but the current behavior allows for rectangular aspect ratios so I stuck with h-auto.

The h-full attribute only seems to be an issue in Safari, as per #3748.

How have you tested this?

Tested with square and rectangular covers. Tested with series and individual books.

Only tested in Firefox, because I do not have access to a Mac for testing on Safari.

Screenshots

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3751 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 12/27/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `rss_feed_image_fix` --- ### 📝 Commits (1) - [`f46b5a5`](https://github.com/advplyr/audiobookshelf/commit/f46b5a533c9ddf83bb1399dc9b3d4a63292d8682) Change: height of RSS feed preview to match aspect ratio ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/config/rss-feeds.vue` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This PR forces the height of the image preview in the RSS feed to be square and match the size of the width. ## Which issue is fixed? This should fix https://github.com/advplyr/audiobookshelf/issues/3748 ## In-depth Description This PR replaces the `h-full` with `h-auto`. I did play with changing this to be a `div` to force the images to be square, but the current behavior allows for rectangular aspect ratios so I stuck with `h-auto`. The `h-full` attribute only seems to be an issue in Safari, as per #3748. ## How have you tested this? Tested with square and rectangular covers. Tested with series and individual books. Only tested in Firefox, because I do not have access to a Mac for testing on Safari. ## Screenshots ![image](https://github.com/user-attachments/assets/1bce3ea6-04f9-49dc-a301-7f70b4a5b587) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:12 +02:00
adam closed this issue 2026-04-25 00:18:12 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?