starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3732] [MERGED] check for mrss item media:content when extracting item enclosures #4066

New Issue
Closed
opened 2026-04-25 00:18:11 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:11 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3732
Author: @Timtam
Created: 12/18/2024
Status: ✅ Merged
Merged: 1/20/2025
Merged by: @advplyr

Base: master ← Head: allow-mrss-item-enclosures-for-podcasts

📝 Commits (3)

  • 4d22417 also check for mrss item enclosures when extracting items
  • 18dfbdd Merge remote-tracking branch 'remotes/upstream/master' into allow-mrss-item-enclosures-for-podcasts
  • bdd8e5b Merge remote-tracking branch 'remotes/upstream/master' into allow-mrss-item-enclosures-for-podcasts

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 server/utils/podcastUtils.js (+8 -4)

📄 Description

Brief summary

Some RSS feeds use the enhanced media RSS format (Mrss), particularly the ones created by Rss Bridge. This format stores its enclosures in media:content tags, which ABS didn't yet understand. This PR adds support for those tags as a fallback from traditional enclosures.

Which issue is fixed?

Fixes #3695

In-depth Description

The function responsible for extracting item episode info will test for enclosure urls first, and if it doesn't find one, it'll search for media:content entries that do have a type that starts with "audio". This is necessary since Mrss also supports storing images within the media:content attributes. If an entry is found, its used as an enclosure, since it seems to have the same tags. If no media:content with audio/something type is found, the function will abort with the usual error.

How have you tested this?

I tested with regular RSS feeds and an Mrss feed. I particularly tested this one: https://rss.nixnet.services/?action=display&bridge=ARDAudiothekBridge&path=https%3A%2F%2Fwww.ardaudiothek.de%2Fsendung%2Fkalk-welk%2F10777871%2F&limit=&format=Mrss

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3732 **Author:** [@Timtam](https://github.com/Timtam) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 1/20/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `allow-mrss-item-enclosures-for-podcasts` --- ### 📝 Commits (3) - [`4d22417`](https://github.com/advplyr/audiobookshelf/commit/4d2241769ec9a7d77926f99cd1986412da4eb0eb) also check for mrss item enclosures when extracting items - [`18dfbdd`](https://github.com/advplyr/audiobookshelf/commit/18dfbdd9830dc8478d5de71bf136a99e211830fd) Merge remote-tracking branch 'remotes/upstream/master' into allow-mrss-item-enclosures-for-podcasts - [`bdd8e5b`](https://github.com/advplyr/audiobookshelf/commit/bdd8e5bb58469ab38c9d59a553cf975ad27893ed) Merge remote-tracking branch 'remotes/upstream/master' into allow-mrss-item-enclosures-for-podcasts ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/podcastUtils.js` (+8 -4) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary <!-- Please provide a brief summary of what your PR attempts to achieve. --> Some RSS feeds use the enhanced media RSS format (Mrss), particularly the ones created by Rss Bridge. This format stores its enclosures in media:content tags, which ABS didn't yet understand. This PR adds support for those tags as a fallback from traditional enclosures. ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> Fixes #3695 ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> The function responsible for extracting item episode info will test for enclosure urls first, and if it doesn't find one, it'll search for media:content entries that do have a type that starts with "audio". This is necessary since Mrss also supports storing images within the media:content attributes. If an entry is found, its used as an enclosure, since it seems to have the same tags. If no media:content with audio/something type is found, the function will abort with the usual error. ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> I tested with regular RSS feeds and an Mrss feed. I particularly tested this one: https://rss.nixnet.services/?action=display&bridge=ARDAudiothekBridge&path=https%3A%2F%2Fwww.ardaudiothek.de%2Fsendung%2Fkalk-welk%2F10777871%2F&limit=&format=Mrss ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:11 +02:00
adam closed this issue 2026-04-25 00:18:11 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4066
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?