starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3671] [CLOSED] Fixing 'Narrators' and 'Series' update on re-scan #4050

New Issue
Closed
opened 2026-04-25 00:18:07 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:07 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3671
Author: @warnwar
Created: 12/2/2024
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

  • 6cd8aef fixing narrator and series update on re-scan

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 server/scanner/AbsMetadataFileScanner.js (+2 -0)

📄 Description

Brief summary

When re-scanning an existing audiobook, I noticed that the 'Narrators' and 'Series' fields will not update if you change the audio tags from empty to something else

Which issue is fixed?

I did not create an issue for this, instead I figured I would fix it myself

In-depth Description

Steps to repro:

  • Add an audiobook to your library. Leave the 'composer' and 'grouping' audio tags empty.
  • Check that audiobookshelf did not somehow pick up data for 'Narrators' and 'Series' fields
  • Outside of audiobookshelf, fill in the empty tags
  • Inside audiobookshelf, click the 'Re-Scan' button
  • See that the two fields are not updated

How have you tested this?

I followed my repro steps listed above, debugging through the code. I found the problem was the AbsMetadataFileScanner.js was overwriting the new 'Narrator' and 'Series' information with empty data.

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3671 **Author:** [@warnwar](https://github.com/warnwar) **Created:** 12/2/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6cd8aef`](https://github.com/advplyr/audiobookshelf/commit/6cd8aef71302baf17c54fc5c2f0ae2d0b959cf4f) fixing narrator and series update on re-scan ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/scanner/AbsMetadataFileScanner.js` (+2 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary When re-scanning an existing audiobook, I noticed that the 'Narrators' and 'Series' fields will not update if you change the audio tags from empty to something else ## Which issue is fixed? I did not create an issue for this, instead I figured I would fix it myself ## In-depth Description Steps to repro: - Add an audiobook to your library. Leave the 'composer' and 'grouping' audio tags empty. - Check that audiobookshelf did not somehow pick up data for 'Narrators' and 'Series' fields - Outside of audiobookshelf, fill in the empty tags - Inside audiobookshelf, click the 'Re-Scan' button - See that the two fields are not updated ## How have you tested this? I followed my repro steps listed above, debugging through the code. I found the problem was the AbsMetadataFileScanner.js was overwriting the new 'Narrator' and 'Series' information with empty data. ## Screenshots --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:07 +02:00
adam closed this issue 2026-04-25 00:18:07 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4050
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?