starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3655] [MERGED] Fix player settings modal on share page #4044

New Issue
Closed
opened 2026-04-25 00:18:06 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:06 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3655
Author: @glorenzen
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/27/2024
Merged by: @advplyr

Base: master ← Head: fix/player-settings-modal

📝 Commits (4)

  • fabdfd5 Add player settings modal to PlayerUi
  • 53fdb52 Remove player settings modal from MediaPlayerContainer
  • 2ba0f91 Update share player to load user settings
  • 718d8b5 Update jump backward amount for share player

📊 Changes

4 files changed (+23 additions, -10 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+0 -4)
📝 client/components/modals/PlayerSettingsModal.vue (+10 -3)
📝 client/components/player/PlayerUi.vue (+7 -1)
📝 client/pages/share/_slug.vue (+6 -2)

📄 Description

Brief summary

I noticed that the player settings modal did not work when playing a book from the share page so I moved the player settings modal state and component to the PlayerUi component to fix this.

Screenshots

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3655 **Author:** [@glorenzen](https://github.com/glorenzen) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/27/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix/player-settings-modal` --- ### 📝 Commits (4) - [`fabdfd5`](https://github.com/advplyr/audiobookshelf/commit/fabdfd5517f805727e50cb25f718564ea68a23af) Add player settings modal to PlayerUi - [`53fdb52`](https://github.com/advplyr/audiobookshelf/commit/53fdb5273ca215b2c257857ddcf660eb08cb6777) Remove player settings modal from MediaPlayerContainer - [`2ba0f91`](https://github.com/advplyr/audiobookshelf/commit/2ba0f9157d1591e930e311943862278f65c91557) Update share player to load user settings - [`718d8b5`](https://github.com/advplyr/audiobookshelf/commit/718d8b599993c676762dae07bd09a73c65971490) Update jump backward amount for share player ### 📊 Changes **4 files changed** (+23 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+0 -4) 📝 `client/components/modals/PlayerSettingsModal.vue` (+10 -3) 📝 `client/components/player/PlayerUi.vue` (+7 -1) 📝 `client/pages/share/_slug.vue` (+6 -2) </details> ### 📄 Description ## Brief summary I noticed that the player settings modal did not work when playing a book from the share page so I moved the player settings modal state and component to the PlayerUi component to fix this. ## Screenshots ![image](https://github.com/user-attachments/assets/80d40a98-af10-43b2-b705-b2b26437b89e) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:06 +02:00
adam closed this issue 2026-04-25 00:18:06 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?