starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3624] [CLOSED] Add: check fields exist in filterData #4039

New Issue
Closed
opened 2026-04-25 00:18:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3624
Author: @nichwall
Created: 11/18/2024
Status: ❌ Closed

Base: master ← Head: fix_filterdata_crash

📝 Commits (1)

  • a326a90 Add: check fields exist in filterData

📊 Changes

1 file changed (+18 additions, -13 deletions)

View changed files

📝 server/utils/queries/libraryFilters.js (+18 -13)

📄 Description

This PR fixes https://github.com/advplyr/audiobookshelf/issues/3623

I do not know if this is the best way to fix this crash (where filterData is missing fields), but I just added a check before comparing against the cached data. This fixes the crash for a new server.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3624 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 11/18/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_filterdata_crash` --- ### 📝 Commits (1) - [`a326a90`](https://github.com/advplyr/audiobookshelf/commit/a326a90417916223c7b93ce6456893a435411a92) Add: check fields exist in `filterData` ### 📊 Changes **1 file changed** (+18 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/queries/libraryFilters.js` (+18 -13) </details> ### 📄 Description This PR fixes https://github.com/advplyr/audiobookshelf/issues/3623 I do not know if this is the best way to fix this crash (where `filterData` is missing fields), but I just added a check before comparing against the cached data. This fixes the crash for a new server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:04 +02:00
adam closed this issue 2026-04-25 00:18:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?