starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3585] [MERGED] Avoid parsing first and last names in Chinese, Japanese and Korean la… #4023

New Issue
Closed
opened 2026-04-25 00:18:01 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:01 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3585
Author: @snakehnb
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (1)

  • 7ef14aa Avoid parsing first and last names in Chinese, Japanese and Korean languages

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 server/utils/parsers/parseNameString.js (+7 -0)

📄 Description

There's no need to parse first and last names in Chinese, Japanese and Korean languages. For example, parsing names from "张三, 李四" or "张三 & 李四" should return ["张三", "李四"], not ["李四 张三"].

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3585 **Author:** [@snakehnb](https://github.com/snakehnb) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`7ef14aa`](https://github.com/advplyr/audiobookshelf/commit/7ef14aabedae8c4a038943633c6b2c2ec52b067e) Avoid parsing first and last names in Chinese, Japanese and Korean languages ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/parsers/parseNameString.js` (+7 -0) </details> ### 📄 Description There's no need to parse first and last names in Chinese, Japanese and Korean languages. For example, parsing names from "张三, 李四" or "张三 & 李四" should return ["张三", "李四"], not ["李四 张三"]. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:01 +02:00
adam closed this issue 2026-04-25 00:18:01 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?