starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3553] [MERGED] Add proper error handing for file downloads #4013

New Issue
Closed
opened 2026-04-25 00:17:58 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:58 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3553
Author: @mikiher
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @advplyr

Base: master ← Head: handle-download-errors

📝 Commits (1)

  • 9084055 Add proper error handing for file downloads

📊 Changes

1 file changed (+43 additions, -16 deletions)

View changed files

📝 server/controllers/LibraryItemController.js (+43 -16)

📄 Description

Fixes #3344

This PR adds proper error handling for file the following file download APIs:

  • /api/items/:id/download
  • /api/items/:id/file/:fileid/download
  • /api/items/:id/ebook/:fileid

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3553 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `handle-download-errors` --- ### 📝 Commits (1) - [`9084055`](https://github.com/advplyr/audiobookshelf/commit/9084055b95417340c003b2f3946753d8f133289d) Add proper error handing for file downloads ### 📊 Changes **1 file changed** (+43 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/LibraryItemController.js` (+43 -16) </details> ### 📄 Description Fixes #3344 This PR adds proper error handling for file the following file download APIs: - `/api/items/:id/download` - `/api/items/:id/file/:fileid/download` - `/api/items/:id/ebook/:fileid` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:58 +02:00
adam closed this issue 2026-04-25 00:17:58 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4013
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?