starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3501] [CLOSED] Library middleware positive check #3995

New Issue
Closed
opened 2026-04-25 00:17:53 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:53 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3501
Author: @nichwall
Created: 10/11/2024
Status: ❌ Closed

Base: master ← Head: library_middleware_positive_check

📝 Commits (2)

  • 7b8709f Fix: undefined limit causes crash in Sequelize
  • aa30791 Change: response to say non-negative

📊 Changes

1 file changed (+3 additions, -5 deletions)

View changed files

📝 server/controllers/LibraryController.js (+3 -5)

📄 Description

This PR fixes https://github.com/advplyr/audiobookshelf/issues/3499.

If one of the pagination values is undefined, it now defaults to 0 to prevent a crash in Sequelize.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3501 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 10/11/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `library_middleware_positive_check` --- ### 📝 Commits (2) - [`7b8709f`](https://github.com/advplyr/audiobookshelf/commit/7b8709f029c71157d027448b363d9d3aeae4eda2) Fix: undefined `limit` causes crash in Sequelize - [`aa30791`](https://github.com/advplyr/audiobookshelf/commit/aa3079189e9a96690791f1eadf5f2235ccfe7b1d) Change: response to say non-negative ### 📊 Changes **1 file changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/LibraryController.js` (+3 -5) </details> ### 📄 Description This PR fixes https://github.com/advplyr/audiobookshelf/issues/3499. If one of the pagination values is undefined, it now defaults to 0 to prevent a crash in Sequelize. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:53 +02:00
adam closed this issue 2026-04-25 00:17:53 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?