starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3500] [MERGED] 2.14.0 string localization #3992

New Issue
Closed
opened 2026-04-25 00:17:52 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:52 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3500
Author: @nichwall
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/12/2024
Merged by: @advplyr

Base: master ← Head: 2_14_0_strings

📝 Commits (5)

  • f98f78a Podcast search strings
  • 29db5f1 Update: tools strings
  • c33b470 Tools Manager strings
  • 8a20510 Localize: subtitle books
  • df6afc9 Add localization for notification descriptions

📊 Changes

7 files changed (+66 additions, -28 deletions)

View changed files

📝 client/components/cards/LazyBookCard.vue (+1 -1)
📝 client/components/modals/item/tabs/Tools.vue (+4 -4)
📝 client/components/modals/notification/NotificationEditModal.vue (+7 -1)
📝 client/pages/audiobook/_id/manage.vue (+17 -17)
📝 client/pages/library/_library/podcast/search.vue (+5 -5)
📝 client/strings/en-us.json (+28 -0)
📝 server/utils/notifications.js (+4 -0)

📄 Description

This PR mostly fixes https://github.com/advplyr/audiobookshelf/issues/3495. This does not change the notification translations. I took a look at https://github.com/advplyr/audiobookshelf/commit/1dec8ae12289638ebbc3d9c763071f7804b92935 for how to add localization for server generated strings, but not sure how to get that to play nice with https://github.com/advplyr/audiobookshelf/blob/master/server/utils/notifications.js.

I did not translate any of the logs. I don't think the logs need to be localized because their primary purpose is to provide debugging information to contributors, where English is the common language.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3500 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/12/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `2_14_0_strings` --- ### 📝 Commits (5) - [`f98f78a`](https://github.com/advplyr/audiobookshelf/commit/f98f78a5bd2673f1cc62e798f18b09fc16f35491) Podcast search strings - [`29db5f1`](https://github.com/advplyr/audiobookshelf/commit/29db5f199095693522cf2e715ebd9c5eab944ae4) Update: tools strings - [`c33b470`](https://github.com/advplyr/audiobookshelf/commit/c33b470fcaf660eb7a59be57dc55587230b00e57) Tools Manager strings - [`8a20510`](https://github.com/advplyr/audiobookshelf/commit/8a20510cde0286eca1790210c471d5bdb59ec2c5) Localize: subtitle `books` - [`df6afc9`](https://github.com/advplyr/audiobookshelf/commit/df6afc957f51e2b46955d6dab7e1fd8649ce6fdd) Add localization for notification descriptions ### 📊 Changes **7 files changed** (+66 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `client/components/cards/LazyBookCard.vue` (+1 -1) 📝 `client/components/modals/item/tabs/Tools.vue` (+4 -4) 📝 `client/components/modals/notification/NotificationEditModal.vue` (+7 -1) 📝 `client/pages/audiobook/_id/manage.vue` (+17 -17) 📝 `client/pages/library/_library/podcast/search.vue` (+5 -5) 📝 `client/strings/en-us.json` (+28 -0) 📝 `server/utils/notifications.js` (+4 -0) </details> ### 📄 Description This PR mostly fixes https://github.com/advplyr/audiobookshelf/issues/3495. This does not change the notification translations. I took a look at https://github.com/advplyr/audiobookshelf/commit/1dec8ae12289638ebbc3d9c763071f7804b92935 for how to add localization for server generated strings, but not sure how to get that to play nice with https://github.com/advplyr/audiobookshelf/blob/master/server/utils/notifications.js. I did not translate any of the logs. I don't think the logs need to be localized because their primary purpose is to provide debugging information to contributors, where English is the common language. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:52 +02:00
adam closed this issue 2026-04-25 00:17:52 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?