starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3492] [MERGED] Use object-cover for author images unless AR is really high or low #3991

New Issue
Closed
opened 2026-04-25 00:17:51 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:51 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3492
Author: @mikiher
Created: 10/9/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @advplyr

Base: master ← Head: author-image-ar

📝 Commits (2)

  • 7653e72 Use object-cover for author images unless AR is really high or low.
  • cfae607 AuthorImage remove aspectRatio unused var

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 client/components/covers/AuthorImage.vue (+1 -6)

📄 Description

While working on lazy loading the Author's page, I felt that we're using object-contain on author images too much - while this works nicely for covers, I feel (subjecively) that the author images look unpolished when we use object-contain. So I modified the current decision algorithm for using object-contain to only use it when the AR is very high or low.

Here's my author page before:
Screenshot 2024-10-09 150942

And after:
Screenshot 2024-10-09 151103

Some of the more significant changed are marked on the After screenshot.

I guess it's really subjective, but I find that I like the After much more, even though in some cases (e.g. John Scalzi), it results in a slightly cut image - but I think in those cases the original looks quite bad as well.

I guess I should also work on allowing users to upload their own author image...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3492 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 10/9/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `author-image-ar` --- ### 📝 Commits (2) - [`7653e72`](https://github.com/advplyr/audiobookshelf/commit/7653e72e88b004764c9f1bce4cfce3332f647f72) Use object-cover for author images unless AR is really high or low. - [`cfae607`](https://github.com/advplyr/audiobookshelf/commit/cfae607310b51384ed66e102e279e26bffbefa17) AuthorImage remove aspectRatio unused var ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `client/components/covers/AuthorImage.vue` (+1 -6) </details> ### 📄 Description While working on lazy loading the Author's page, I felt that we're using object-contain on author images too much - while this works nicely for covers, I feel (subjecively) that the author images look unpolished when we use object-contain. So I modified the current decision algorithm for using object-contain to only use it when the AR is very high or low. Here's my author page before: ![Screenshot 2024-10-09 150942](https://github.com/user-attachments/assets/ea1e5a78-2673-473f-82ca-38e9e1051541) And after: <img width="1733" alt="Screenshot 2024-10-09 151103" src="https://github.com/user-attachments/assets/d68a1f54-8586-419b-bcfe-77415109c762"> Some of the more significant changed are marked on the After screenshot. I guess it's really subjective, but I find that I like the After much more, even though in some cases (e.g. John Scalzi), it results in a slightly cut image - but I think in those cases the original looks quite bad as well. I guess I should also work on allowing users to upload their own author image... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:51 +02:00
adam closed this issue 2026-04-25 00:17:52 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?