starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3488] [MERGED] Use musl-based libnusqlite3 in Docker #3988

New Issue
Closed
opened 2026-04-25 00:17:51 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:51 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3488
Author: @mikiher
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @advplyr

Base: master ← Head: nunicode-musl

📝 Commits (1)

  • d926260 Use musl-based libnusqlite3 in Docker

📊 Changes

2 files changed (+3 additions, -4 deletions)

View changed files

📝 Dockerfile (+2 -3)
📝 server/managers/BinaryManager.js (+1 -1)

📄 Description

Following @devnoname120's advice, I am switching to a musl-based nunicode sqlite extension on Docker, and doing away with installing and relying on gcompat (which is no longer needed). The new musl-based binaries are obtained from the new v1.2 version of nunicode-binaries.

Other nunicode binaries remain unchanged, but I switched to v1.2 in BinaryManager as well, to keep the versions consistent.

Note: BinaryManager doesn't check the exact linux version and always installs the standard glibc-based version. This means that running if you run on a non-Docker Alpine (probably as a developer), you will have to install gcomapt manually for the program to load. I think this is OK, but let me know if you want me to add a special use-case for Alpine in BinaryManager.

I tested on Docker on both architectures.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3488 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `nunicode-musl` --- ### 📝 Commits (1) - [`d926260`](https://github.com/advplyr/audiobookshelf/commit/d92626071e70774978fe0a3e570435c19fabe60e) Use musl-based libnusqlite3 in Docker ### 📊 Changes **2 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+2 -3) 📝 `server/managers/BinaryManager.js` (+1 -1) </details> ### 📄 Description Following @devnoname120's advice, I am switching to a musl-based nunicode sqlite extension on Docker, and doing away with installing and relying on gcompat (which is no longer needed). The new musl-based binaries are obtained from the new v1.2 version of nunicode-binaries. Other nunicode binaries remain unchanged, but I switched to v1.2 in BinaryManager as well, to keep the versions consistent. Note: BinaryManager doesn't check the exact linux version and always installs the standard glibc-based version. This means that running if you run on a non-Docker Alpine (probably as a developer), you will have to install gcomapt manually for the program to load. I think this is OK, but let me know if you want me to add a special use-case for Alpine in BinaryManager. I tested on Docker on both architectures. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:51 +02:00
adam closed this issue 2026-04-25 00:17:51 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3988
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?