starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3454] [CLOSED] Add: abs databases from before v2.13.4 #3980

New Issue
Closed
opened 2026-04-25 00:17:49 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:49 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3454
Author: @nichwall
Created: 9/25/2024
Status: ❌ Closed

Base: master ← Head: test_databases

📝 Commits (1)

  • 258aac0 Add: abs databases from before v2.13.4

📊 Changes

31 files changed (+1035 additions, -0 deletions)

View changed files

➕ test/server/testdata/schema_v2.10.0.sql (+36 -0)
➕ test/server/testdata/schema_v2.10.1.sql (+36 -0)
➕ test/server/testdata/schema_v2.11.0.sql (+37 -0)
➕ test/server/testdata/schema_v2.12.0.sql (+37 -0)
➕ test/server/testdata/schema_v2.12.1.sql (+37 -0)
➕ test/server/testdata/schema_v2.12.2.sql (+37 -0)
➕ test/server/testdata/schema_v2.12.3.sql (+37 -0)
➕ test/server/testdata/schema_v2.13.0.sql (+37 -0)
➕ test/server/testdata/schema_v2.13.1.sql (+37 -0)
➕ test/server/testdata/schema_v2.13.2.sql (+37 -0)
➕ test/server/testdata/schema_v2.13.3.sql (+37 -0)
➕ test/server/testdata/schema_v2.13.4.sql (+37 -0)
➕ test/server/testdata/schema_v2.3.0.sql (+21 -0)
➕ test/server/testdata/schema_v2.3.1.sql (+21 -0)
➕ test/server/testdata/schema_v2.3.2.sql (+21 -0)
➕ test/server/testdata/schema_v2.3.3.sql (+21 -0)
➕ test/server/testdata/schema_v2.3.4.sql (+33 -0)
➕ test/server/testdata/schema_v2.3.5.sql (+33 -0)
➕ test/server/testdata/schema_v2.4.0.sql (+33 -0)
➕ test/server/testdata/schema_v2.4.1.sql (+30 -0)

...and 11 more files

📄 Description

This PR adds test databases for each ABS server version to test/server/testdata, using the naming scheme of schema_v[version].sql. These databases were created by:

  • Checking out each release beginning with 2.3.0 and ensuring the correct version of node was used (node 16 prior to v2.8.0, node 20 afterwards)
  • Deleting the 'config/` directory to ensure we started from a clean state
  • Starting the server
  • Running sqlite3 config/absdatabase.sqlite ".schema" > "schema_v[version].sql"

This inspiration was taken from comments in the PR about series migrations, specifically https://github.com/advplyr/audiobookshelf/pull/3417#issuecomment-2351115265. A different directory could be used for these databases, but I didn't have a better suggestion than was mentioned there.

We don't really need every database beginning with 2.3.0, but am including them all for completeness.

Follow-up

Would it be useful to have a GH workflow which can be manually triggered (probably after the version bump commit, but before release?) to run the sqlite dump command and open a PR with the new SQL file? This would be merged manually, but then is a button press instead of needing to remember to clean out config/, start the server, and move/rename the file.

If so, I will do that in a separate PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3454 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 9/25/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `test_databases` --- ### 📝 Commits (1) - [`258aac0`](https://github.com/advplyr/audiobookshelf/commit/258aac0690800433fff2d0b655d4103a0a4113aa) Add: abs databases from before v2.13.4 ### 📊 Changes **31 files changed** (+1035 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `test/server/testdata/schema_v2.10.0.sql` (+36 -0) ➕ `test/server/testdata/schema_v2.10.1.sql` (+36 -0) ➕ `test/server/testdata/schema_v2.11.0.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.12.0.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.12.1.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.12.2.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.12.3.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.13.0.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.13.1.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.13.2.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.13.3.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.13.4.sql` (+37 -0) ➕ `test/server/testdata/schema_v2.3.0.sql` (+21 -0) ➕ `test/server/testdata/schema_v2.3.1.sql` (+21 -0) ➕ `test/server/testdata/schema_v2.3.2.sql` (+21 -0) ➕ `test/server/testdata/schema_v2.3.3.sql` (+21 -0) ➕ `test/server/testdata/schema_v2.3.4.sql` (+33 -0) ➕ `test/server/testdata/schema_v2.3.5.sql` (+33 -0) ➕ `test/server/testdata/schema_v2.4.0.sql` (+33 -0) ➕ `test/server/testdata/schema_v2.4.1.sql` (+30 -0) _...and 11 more files_ </details> ### 📄 Description This PR adds test databases for each ABS server version to `test/server/testdata`, using the naming scheme of `schema_v[version].sql`. These databases were created by: - Checking out each release beginning with 2.3.0 and ensuring the correct version of node was used (node 16 prior to v2.8.0, node 20 afterwards) - Deleting the 'config/` directory to ensure we started from a clean state - Starting the server - Running `sqlite3 config/absdatabase.sqlite ".schema" > "schema_v[version].sql"` This inspiration was taken from comments in the PR about series migrations, specifically https://github.com/advplyr/audiobookshelf/pull/3417#issuecomment-2351115265. A different directory could be used for these databases, but I didn't have a better suggestion than was mentioned there. We don't *really* need every database beginning with 2.3.0, but am including them all for completeness. ### Follow-up Would it be useful to have a GH workflow which can be manually triggered (probably after the version bump commit, but before release?) to run the sqlite dump command and open a PR with the new SQL file? This would be merged manually, but then is a button press instead of needing to remember to clean out `config/`, start the server, and move/rename the file. If so, I will do that in a separate PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:49 +02:00
adam closed this issue 2026-04-25 00:17:49 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3980
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?