starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3451] [Help needed] Misc. RSS Improvements #3978

New Issue
Open
opened 2026-04-25 00:17:48 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:48 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3451
Author: @kieraneglin
Created: 9/24/2024
Status: 🔄 Open

Base: master ← Head: ke/rss-improvements

📝 Commits (2)

  • a15324c Converted podcast duration to seconds
  • 4de8bb5 [WIP] Adding images to all RSS feed items

📊 Changes

3 files changed (+33 additions, -6 deletions)

View changed files

📝 server/Server.js (+3 -0)
📝 server/managers/RssFeedManager.js (+16 -0)
📝 server/objects/FeedEpisode.js (+14 -6)

📄 Description

What's new?

  • Drops non-standard duration formatting for RSS feed items. Duration is now represented using full seconds
  • [WIP] Adds an image for each item in a collection

It's that last one that I need help on. After tracing it out, I've realized that the FeedEpisode model doesn't have a coverPath attribute for displaying an image.

I could bypass that entirely and instead get the item's cover directly instead of going through Feed > FeedEpisode, but I'm not sure if that's something you'd be open to. Or maybe it's best to add a coverPath to FeedEpisode and do it that way

Please let me know if you have any tips!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3451 **Author:** [@kieraneglin](https://github.com/kieraneglin) **Created:** 9/24/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `ke/rss-improvements` --- ### 📝 Commits (2) - [`a15324c`](https://github.com/advplyr/audiobookshelf/commit/a15324cb971a08b76ea652b52c01f106543ef136) Converted podcast duration to seconds - [`4de8bb5`](https://github.com/advplyr/audiobookshelf/commit/4de8bb59496ea6bfeffe7062deacaa17243c2307) [WIP] Adding images to all RSS feed items ### 📊 Changes **3 files changed** (+33 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/Server.js` (+3 -0) 📝 `server/managers/RssFeedManager.js` (+16 -0) 📝 `server/objects/FeedEpisode.js` (+14 -6) </details> ### 📄 Description ## What's new? - Drops non-standard duration formatting for RSS feed items. Duration is now represented using full seconds - [WIP] Adds an image for each item in a collection It's that last one that I need help on. After tracing it out, I've realized that the `FeedEpisode` model doesn't have a `coverPath` attribute for displaying an image. I could bypass that entirely and instead get the item's cover directly instead of going through `Feed` > `FeedEpisode`, but I'm not sure if that's something you'd be open to. Or maybe it's best to add a `coverPath` to `FeedEpisode` and do it that way Please let me know if you have any tips! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:48 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?