starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3329] [MERGED] Fix embed and convert for single file library items #3936

New Issue
Closed
opened 2026-04-25 00:17:38 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:38 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3329
Author: @mikiher
Created: 8/24/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @advplyr

Base: master ← Head: embed-single-file

📝 Commits (1)

  • 4d8e1b7 Fix embed and convert for single file library items

📊 Changes

2 files changed (+20 additions, -12 deletions)

View changed files

📝 server/managers/AbMergeManager.js (+7 -6)
📝 server/managers/AudioMetadataManager.js (+13 -6)

📄 Description

This fixes #3323

The fix applies to both m4b conversion and metadata embedding when they are applied to single-file library items in the library's root folder.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3329 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 8/24/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `embed-single-file` --- ### 📝 Commits (1) - [`4d8e1b7`](https://github.com/advplyr/audiobookshelf/commit/4d8e1b7cef40705ba0d1c2bfb35b1448397af6eb) Fix embed and convert for single file library items ### 📊 Changes **2 files changed** (+20 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/AbMergeManager.js` (+7 -6) 📝 `server/managers/AudioMetadataManager.js` (+13 -6) </details> ### 📄 Description This fixes #3323 The fix applies to both m4b conversion and metadata embedding when they are applied to single-file library items in the library's root folder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:38 +02:00
adam closed this issue 2026-04-25 00:17:38 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3936
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?