mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[PR #3326] [CLOSED] Series cleanup #3935
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#3935
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/advplyr/audiobookshelf/pull/3326
Author: @nichwall
Created: 8/23/2024
Status: ❌ Closed
Base:
master← Head:series_cleanup📝 Commits (10+)
e7eda12Add: deduplicate series on server startup896f2d4Duplicate series need to have the same libraryId926896eAdd: logging of how many series were removed4f6297eUpdate spacing9b87d55Updates to use new Library modela250915Update series and collection width to account for book aspect ratio7a68dfcFix embed and convert for single file library items9ffdf59Updates to LibraryController to use new Library model9fedebaUpdates to migrate off of old library model8bfca41Fix:Check if book is already being merged before allowing to start #3331📊 Changes
201 files changed (+10352 additions, -9598 deletions)
View changed files
➕
.github/workflows/apply_comments.yaml(+55 -0)📝
client/components/app/Appbar.vue(+2 -3)📝
client/components/app/BookShelfToolbar.vue(+8 -12)📝
client/components/app/MediaPlayerContainer.vue(+2 -11)📝
client/components/app/SideRail.vue(+0 -14)📝
client/components/cards/LazyBookCard.vue(+20 -44)📝
client/components/cards/LazyCollectionCard.vue(+1 -13)📝
client/components/cards/LazySeriesCard.vue(+2 -2)📝
client/components/cards/NotificationCard.vue(+13 -15)📝
client/components/content/LibraryItemDetails.vue(+2 -57)📝
client/components/controls/GlobalSearch.vue(+1 -1)📝
client/components/controls/LibraryFilterSelect.vue(+0 -29)📝
client/components/controls/LibrarySortSelect.vue(+0 -33)📝
client/components/modals/AccountModal.vue(+11 -11)📝
client/components/modals/AddCustomMetadataProviderModal.vue(+5 -5)📝
client/components/modals/AudioFileDataModal.vue(+2 -2)📝
client/components/modals/BackupScheduleModal.vue(+1 -1)📝
client/components/modals/BookmarksModal.vue(+1 -1)📝
client/components/modals/ListeningSessionModal.vue(+2 -3)📝
client/components/modals/ShareModal.vue(+1 -1)...and 80 more files
📄 Description
This PR fixes https://github.com/advplyr/audiobookshelf/issues/3207 by combining series that have identical names and the same
libraryId. I originally only used the series name, but realized that the same series may exist in two different libraries.This PR does not fix the "duplicate entries" causing problems for the InputDropdown component, and instead fixes the data in the database itself.
This is done by adding a cleanup function to server startup which updates all
bookSeriesentries that have duplicate series names and libraryIds to point to the newest series, and then deletes the now-unused duplicates.This will help handle issues with series from previous server versions, but I am not sure of the root cause of duplicate series (whether from a scanner, matching, or manual editing of an item). I briefly looked at all occurrences of
SeriesModeland did not see anything that looked like it could cause duplicate series like this, so it may be a leftover bug from an older server version.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.