starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3328] [MERGED] Update series and collection width to account for book aspect ratio #3934

New Issue
Closed
opened 2026-04-25 00:17:37 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:37 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3328
Author: @mikiher
Created: 8/24/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @advplyr

Base: master ← Head: aspect-ratio-card-width

📝 Commits (1)

  • 6d3e096 Update series and collection width to account for book aspect ratio

📊 Changes

3 files changed (+2 additions, -31 deletions)

View changed files

📝 client/components/cards/LazyBookCard.vue (+0 -17)
📝 client/components/cards/LazyCollectionCard.vue (+1 -13)
📝 client/components/cards/LazySeriesCard.vue (+1 -1)

📄 Description

This addresses @advplyr's comment on PR #3037

I fixed cardWidth() on both Series and Collection cards to account for the aspect ratio correctly.

I checked against the Series and Collections pages as they were in v2.10.1 (before PR 3037 was integrated), and now they look the same. Sorry for missing this on that PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3328 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 8/24/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `aspect-ratio-card-width` --- ### 📝 Commits (1) - [`6d3e096`](https://github.com/advplyr/audiobookshelf/commit/6d3e096e08ceed1660a2b84c10f24cf265547ba5) Update series and collection width to account for book aspect ratio ### 📊 Changes **3 files changed** (+2 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `client/components/cards/LazyBookCard.vue` (+0 -17) 📝 `client/components/cards/LazyCollectionCard.vue` (+1 -13) 📝 `client/components/cards/LazySeriesCard.vue` (+1 -1) </details> ### 📄 Description This addresses @advplyr's [comment](https://github.com/advplyr/audiobookshelf/pull/3037#issuecomment-2303164251) on PR #3037 I fixed cardWidth() on both Series and Collection cards to account for the aspect ratio correctly. I checked against the Series and Collections pages as they were in v2.10.1 (before PR 3037 was integrated), and now they look the same. Sorry for missing this on that PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:37 +02:00
adam closed this issue 2026-04-25 00:17:38 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3934
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?