starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3278] [MERGED] Go back to downloading binaries from ffbinaries.com #3922

New Issue
Closed
opened 2026-04-25 00:17:34 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:34 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3278
Author: @mikiher
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @advplyr

Base: master ← Head: revert-to-ffbinaries

📝 Commits (1)

  • 02e5d60 Go back to downloading binaries from ffbinaries.com

📊 Changes

1 file changed (+71 additions, -101 deletions)

View changed files

📝 server/managers/BinaryManager.js (+71 -101)

📄 Description

This is in continuation to our discussion in #3199, in which we decided not download binaries from Github due to rate-limiting on unauthenticated API requests.

This re-implements downloading from ffbinaries (using roughly the same class and methods used for downloading from Github, and not introducing back libs/ffbinaries), and removes support for Github downloading.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3278 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `revert-to-ffbinaries` --- ### 📝 Commits (1) - [`02e5d60`](https://github.com/advplyr/audiobookshelf/commit/02e5d608d01539f719a4b9df6a3339ecc9dab59c) Go back to downloading binaries from ffbinaries.com ### 📊 Changes **1 file changed** (+71 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/BinaryManager.js` (+71 -101) </details> ### 📄 Description This is in continuation to our discussion in #3199, in which we decided not download binaries from Github due to rate-limiting on unauthenticated API requests. This re-implements downloading from ffbinaries (using roughly the same class and methods used for downloading from Github, and _not_ introducing back libs/ffbinaries), and removes support for Github downloading. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:34 +02:00
adam closed this issue 2026-04-25 00:17:34 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?