starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3262] [MERGED] lang/localization of "year in review" #3920

New Issue
Closed
opened 2026-04-25 00:17:34 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:34 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3262
Author: @Vito0912
Created: 8/9/2024
Status: ✅ Merged
Merged: 8/9/2024
Merged by: @advplyr

Base: master ← Head: lang/add-year-in-review

📝 Commits (3)

📊 Changes

4 files changed (+54 additions, -29 deletions)

View changed files

📝 client/components/stats/YearInReview.vue (+15 -13)
📝 client/components/stats/YearInReviewServer.vue (+14 -12)
📝 client/components/stats/YearInReviewShort.vue (+6 -4)
📝 client/strings/en-us.json (+19 -0)

📄 Description

This PR adds localization for the shareable image on the Stats page (also known as "YEAR IN REVIEW").

It's important to note that since this is an image/canvas and the text is "drawn" onto it, the length of the text is not truly flexible, as the boxes/containers do not adjust accordingly.

I suggest adding a note in Weblate to inform translators that this string should not be too long and setting a "soft limit" to proactively warn when a certain character limit is exceeded. Of course, some characters are longer or shorter, but this would serve as a guideline.

closes #3260

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3262 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 8/9/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `lang/add-year-in-review` --- ### 📝 Commits (3) - [`e10c809`](https://github.com/advplyr/audiobookshelf/commit/e10c8093c97525bce31e77b6c224ead851b1ffd8) localization of year in review - [`e701d1a`](https://github.com/advplyr/audiobookshelf/commit/e701d1ab6a9879f04bf8285f44f11e88a02787f3) now? please - [`f0c6dcc`](https://github.com/advplyr/audiobookshelf/commit/f0c6dccadbdaed7e3946f6f6967785793e887aec) Added max width ### 📊 Changes **4 files changed** (+54 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `client/components/stats/YearInReview.vue` (+15 -13) 📝 `client/components/stats/YearInReviewServer.vue` (+14 -12) 📝 `client/components/stats/YearInReviewShort.vue` (+6 -4) 📝 `client/strings/en-us.json` (+19 -0) </details> ### 📄 Description This PR adds localization for the shareable image on the Stats page (also known as "YEAR IN REVIEW"). It's important to note that since this is an image/canvas and the text is "drawn" onto it, the length of the text is not truly flexible, as the boxes/containers do not adjust accordingly. I suggest adding a note in Weblate to inform translators that this string should not be too long and setting a "soft limit" to proactively warn when a certain character limit is exceeded. Of course, some characters are longer or shorter, but this would serve as a guideline. closes #3260 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:34 +02:00
adam closed this issue 2026-04-25 00:17:34 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3920
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?