starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3225] [MERGED] Add: Backup notification #3909

New Issue
Closed
opened 2026-04-25 00:17:32 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:32 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3225
Author: @nichwall
Created: 8/4/2024
Status: ✅ Merged
Merged: 8/18/2024
Merged by: @advplyr

Base: master ← Head: backup_notification

📝 Commits (9)

  • 2aabca9 Formatting updates
  • b1adafe Add: backup completion notification
  • 1ef78d0 Fix: comment for backup
  • 37cf019 Add: backup size units to notification
  • d6b5363 Add: failed backup notification
  • 0789f6f Add: calls to failed backup notification
  • 7231bc5 Update: notification OpenAPI spec
  • 0da9938 Update notifications to first check if any are active for an event, update JS docs
  • 7c86703 remove unicode file

📊 Changes

7 files changed (+144 additions, -25 deletions)

View changed files

📝 docs/objects/Notification.yaml (+1 -1)
📝 docs/openapi.json (+2 -0)
📝 server/Server.js (+1 -1)
📝 server/managers/BackupManager.js (+13 -3)
📝 server/managers/NotificationManager.js (+77 -12)
📝 server/objects/settings/NotificationSettings.js (+20 -8)
📝 server/utils/notifications.js (+30 -0)

📄 Description

Fixes https://github.com/advplyr/audiobookshelf/issues/3158

This PR adds two new notifications related to backups (successful and failed). I wasn't sure what to put in the failed e-mail, but figured sending the error and directing the admin to the server logs was a good place to start. I also updated the OpenAPI spec for the notification endpoint.

backup_success

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3225 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 8/4/2024 **Status:** ✅ Merged **Merged:** 8/18/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `backup_notification` --- ### 📝 Commits (9) - [`2aabca9`](https://github.com/advplyr/audiobookshelf/commit/2aabca906e85da01a1372f19f5d4d4d0386ae998) Formatting updates - [`b1adafe`](https://github.com/advplyr/audiobookshelf/commit/b1adafedd24aae9ed18bfeefdfc518000d270a5c) Add: backup completion notification - [`1ef78d0`](https://github.com/advplyr/audiobookshelf/commit/1ef78d069dabd1e35633680b074891f81ad99876) Fix: comment for backup - [`37cf019`](https://github.com/advplyr/audiobookshelf/commit/37cf019e99fb4ba614f7a2e032dd51ce6edf9aaa) Add: backup size units to notification - [`d6b5363`](https://github.com/advplyr/audiobookshelf/commit/d6b5363ab9387f62663f8d3e9a9c01ed080b22db) Add: failed backup notification - [`0789f6f`](https://github.com/advplyr/audiobookshelf/commit/0789f6faf7d7e39227744f2b53dfb4cedcf3d9f0) Add: calls to failed backup notification - [`7231bc5`](https://github.com/advplyr/audiobookshelf/commit/7231bc59979df311c9f3771feebbc26659df3a41) Update: notification OpenAPI spec - [`0da9938`](https://github.com/advplyr/audiobookshelf/commit/0da9938698c12b6a11909bb81686a69e344ece30) Update notifications to first check if any are active for an event, update JS docs - [`7c86703`](https://github.com/advplyr/audiobookshelf/commit/7c86703339438eb4d94bd295be3240314f96a3db) remove unicode file ### 📊 Changes **7 files changed** (+144 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `docs/objects/Notification.yaml` (+1 -1) 📝 `docs/openapi.json` (+2 -0) 📝 `server/Server.js` (+1 -1) 📝 `server/managers/BackupManager.js` (+13 -3) 📝 `server/managers/NotificationManager.js` (+77 -12) 📝 `server/objects/settings/NotificationSettings.js` (+20 -8) 📝 `server/utils/notifications.js` (+30 -0) </details> ### 📄 Description Fixes https://github.com/advplyr/audiobookshelf/issues/3158 This PR adds two new notifications related to backups (successful and failed). I wasn't sure what to put in the failed e-mail, but figured sending the error and directing the admin to the server logs was a good place to start. I also updated the OpenAPI spec for the notification endpoint. ![backup_success](https://github.com/user-attachments/assets/00deaf6e-be02-4ad2-be5c-b797e069cecd) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:32 +02:00
adam closed this issue 2026-04-25 00:17:32 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?