starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3214] [MERGED] persist and show the advanced encoding options #3903

New Issue
Closed
opened 2026-04-25 00:17:30 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:30 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3214
Author: @faush01
Created: 7/31/2024
Status: ✅ Merged
Merged: 7/31/2024
Merged by: @advplyr

Base: master ← Head: feature/persist_encoding_options

📝 Commits (1)

  • 49054d5 persist the advanced encoding options, show the encoding options used with in progress encodes

📊 Changes

2 files changed (+29 additions, -6 deletions)

View changed files

📝 client/pages/audiobook/_id/manage.vue (+27 -5)
📝 server/managers/AbMergeManager.js (+2 -1)

📄 Description

The changes allow two things:

1 - persist the advanced encoding settings so they can used as the default advanced settings

  • Saves the advanced bitrate, channels, codec to local storage
  • Populates the saved values if you select used advanced options

2 - Saves the advanced settings used for an encode task to the task.data so they can be shown in the in progress dialog

  • Saves the passed in advanced encode options in the Task data filed
  • When viewing an in progress encode task it uses these to show what the current encode is using

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3214 **Author:** [@faush01](https://github.com/faush01) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 7/31/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feature/persist_encoding_options` --- ### 📝 Commits (1) - [`49054d5`](https://github.com/advplyr/audiobookshelf/commit/49054d5239380c36027b5f09375acfd474656afb) persist the advanced encoding options, show the encoding options used with in progress encodes ### 📊 Changes **2 files changed** (+29 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/manage.vue` (+27 -5) 📝 `server/managers/AbMergeManager.js` (+2 -1) </details> ### 📄 Description The changes allow two things: 1 - persist the advanced encoding settings so they can used as the default advanced settings - Saves the advanced bitrate, channels, codec to local storage - Populates the saved values if you select used advanced options 2 - Saves the advanced settings used for an encode task to the task.data so they can be shown in the in progress dialog - Saves the passed in advanced encode options in the Task data filed - When viewing an in progress encode task it uses these to show what the current encode is using --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:30 +02:00
adam closed this issue 2026-04-25 00:17:30 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?