starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3210] [CLOSED] Fix: Filter undefined entries from loadExtensions array #3901

New Issue
Closed
opened 2026-04-25 00:17:30 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:30 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3210
Author: @OISumeko
Created: 7/30/2024
Status: ❌ Closed

Base: master ← Head: load-extensions-fix

📝 Commits (2)

  • 09c95aa Fix: loadExtensions filters undefined entries before loading
  • 844835f Reverted change to loadExtensions, updated to remove SKIP_BINARIES_CHECK

📊 Changes

3 files changed (+2 additions, -10 deletions)

View changed files

📝 .devcontainer/dev.js (+2 -3)
📝 index.js (+0 -1)
📝 server/managers/BinaryManager.js (+0 -6)

📄 Description

This PR fixes an issue introduced in #3199, where the server would crash on startup if SQLEAN_UNICODE_PATH was not set.

As I'm not sure if loadExtensions will be used in other locations in the future, I figured filtering out undefined entries within the function might be preferable to to simply checking for a valid SQLEAN_UNICODE_PATH value before calling it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3210 **Author:** [@OISumeko](https://github.com/OISumeko) **Created:** 7/30/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `load-extensions-fix` --- ### 📝 Commits (2) - [`09c95aa`](https://github.com/advplyr/audiobookshelf/commit/09c95aa8459d5fa8e1dfdd337cdc4c7178734d4a) Fix: loadExtensions filters undefined entries before loading - [`844835f`](https://github.com/advplyr/audiobookshelf/commit/844835f79756d89c9d2b652cc12cfd8277dccd6e) Reverted change to loadExtensions, updated to remove SKIP_BINARIES_CHECK ### 📊 Changes **3 files changed** (+2 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/dev.js` (+2 -3) 📝 `index.js` (+0 -1) 📝 `server/managers/BinaryManager.js` (+0 -6) </details> ### 📄 Description This PR fixes an issue introduced in #3199, where the server would crash on startup if `SQLEAN_UNICODE_PATH` was not set. As I'm not sure if `loadExtensions` will be used in other locations in the future, I figured filtering out `undefined` entries within the function might be preferable to to simply checking for a valid `SQLEAN_UNICODE_PATH` value before calling it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:30 +02:00
adam closed this issue 2026-04-25 00:17:30 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?