starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3151] [MERGED] WIP: Add "End of chapter" option for sleep timer #3882

New Issue
Closed
opened 2026-04-25 00:17:25 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:25 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3151
Author: @glorenzen
Created: 7/11/2024
Status: ✅ Merged
Merged: 7/14/2024
Merged by: @advplyr

Base: master ← Head: sleep-end-of-chapter

📝 Commits (10+)

  • 41e3965 Add SleepTimerTypes for countdown and chapter
  • cd902c0 Add functionality for 'end of chapter' sleep timer
  • b989b9f Fix custom time for sleep timer
  • aa2c132 Include end of chapter string for sleep timer
  • 549d077 Increase chapter end tolerance to 0.75
  • 63541ff Show sleep time options in modal when timer is active
  • 453263b Add SleepTimerTypes for countdown and chapter
  • 0f35e72 Add functionality for 'end of chapter' sleep timer
  • 7595682 Fix custom time for sleep timer
  • 0c2f8b7 Include end of chapter string for sleep timer

📊 Changes

7 files changed (+131 additions, -79 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+35 -10)
📝 client/components/modals/PlayerSettingsModal.vue (+6 -6)
📝 client/components/modals/SleepTimerModal.vue (+60 -45)
📝 client/components/player/PlayerPlaybackControls.vue (+2 -2)
📝 client/components/player/PlayerUi.vue (+16 -13)
📝 client/plugins/constants.js (+7 -1)
📝 client/strings/en-us.json (+5 -2)

📄 Description

This adds a new "end of chapter" option for the sleep timer.

The sleep timer is working, there are just some UI adjustments that need to be made, such as the modal that has the increment and decrement options while the sleep timer is running, and the sleep timer remaining text in the player UI.

Any feedback is welcome!

This resolves #2059

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3151 **Author:** [@glorenzen](https://github.com/glorenzen) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `sleep-end-of-chapter` --- ### 📝 Commits (10+) - [`41e3965`](https://github.com/advplyr/audiobookshelf/commit/41e39654678496eacf5bb67f6a22bda74cbd3e58) Add SleepTimerTypes for countdown and chapter - [`cd902c0`](https://github.com/advplyr/audiobookshelf/commit/cd902c06365732508e60c26cdce4fbf485bdc6ff) Add functionality for 'end of chapter' sleep timer - [`b989b9f`](https://github.com/advplyr/audiobookshelf/commit/b989b9fa4cd9f1676c967a924c9a99225ececcbd) Fix custom time for sleep timer - [`aa2c132`](https://github.com/advplyr/audiobookshelf/commit/aa2c13262149f5b15ac2f5f0e3416079a99bb4d4) Include end of chapter string for sleep timer - [`549d077`](https://github.com/advplyr/audiobookshelf/commit/549d0770e277ff1c39d0160a95a2dc897c3735d7) Increase chapter end tolerance to 0.75 - [`63541ff`](https://github.com/advplyr/audiobookshelf/commit/63541ffb73cc63bbbfb58bef9c64ff16d661907c) Show sleep time options in modal when timer is active - [`453263b`](https://github.com/advplyr/audiobookshelf/commit/453263b4e7fa388607ff3cec77982f38769456b3) Add SleepTimerTypes for countdown and chapter - [`0f35e72`](https://github.com/advplyr/audiobookshelf/commit/0f35e72b78ba53fa6cb6094c24dd29ba499b2ac0) Add functionality for 'end of chapter' sleep timer - [`7595682`](https://github.com/advplyr/audiobookshelf/commit/75956822457b8a1e027ba5bf1342f8d75819ac78) Fix custom time for sleep timer - [`0c2f8b7`](https://github.com/advplyr/audiobookshelf/commit/0c2f8b70d3acb0f3f49ce0e6222dc164c17f42ff) Include end of chapter string for sleep timer ### 📊 Changes **7 files changed** (+131 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+35 -10) 📝 `client/components/modals/PlayerSettingsModal.vue` (+6 -6) 📝 `client/components/modals/SleepTimerModal.vue` (+60 -45) 📝 `client/components/player/PlayerPlaybackControls.vue` (+2 -2) 📝 `client/components/player/PlayerUi.vue` (+16 -13) 📝 `client/plugins/constants.js` (+7 -1) 📝 `client/strings/en-us.json` (+5 -2) </details> ### 📄 Description This adds a new "end of chapter" option for the sleep timer. The sleep timer is working, there are just some UI adjustments that need to be made, such as the modal that has the increment and decrement options while the sleep timer is running, and the sleep timer remaining text in the player UI. Any feedback is welcome! This resolves #2059 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:25 +02:00
adam closed this issue 2026-04-25 00:17:25 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?