starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3117] [MERGED] New feature: Show Subtitles #3872

New Issue
Closed
opened 2026-04-25 00:17:23 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:23 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3117
Author: @mikiher
Created: 7/4/2024
Status: ✅ Merged
Merged: 7/9/2024
Merged by: @advplyr

Base: master ← Head: show-subtitles

📝 Commits (7)

  • 6b6df61 Remove tailwind.compiled.css (auto-generated, added by mistake)
  • 54f2bb1 Add a Show Subtitles option
  • 0042604 Merge branch 'advplyr:master' into show-subtitles
  • 79bd6a2 Move Collapse Series option to the tollbar's context menu
  • 31c8cb4 Make menu item localized where they're not
  • eb5af47 Merge branch 'master' into show-subtitles
  • 8c4afa1 Fix typo

📊 Changes

7 files changed (+117 additions, -4682 deletions)

View changed files

📝 client/components/app/Appbar.vue (+2 -2)
📝 client/components/app/BookShelfToolbar.vue (+79 -6)
📝 client/components/cards/LazyBookCard.vue (+18 -1)
➖ client/cypress/support/tailwind.compiled.css (+0 -4672)
📝 client/cypress/tests/components/cards/LazyBookCard.cy.js (+11 -1)
📝 client/store/user.js (+1 -0)
📝 client/strings/en-us.json (+6 -0)

📄 Description

Fixes #2774.

This re-introduces a feature removed from #3037 after some comments from @advplyr :

I don't think we should include the show subtitles in this PR.
It doesn't make sense to show that setting on the regular bookshelf view. It is too tight on mobile for the library page. I think we should use a context menu dropdown if we add more checkboxes to the bookshelf toolbar. Showing series and genres there confused me at first and when it is empty it looks weird.

This is a re-write of that feature taking those comments into account.

  • The Show/Hide Subtitles setting has been moved to the Toolbar's context menu dropdown
  • The subtitle field shows the subtitle from the metadata, if it exists, or the book's series and sequence if it doesn't.
    • No genres in this version, but I think series and sequence make sense if there's no subtitle.
    • This is only shown for books, not for podcasts
  • For a collpased-series entry, the subtitle shows the number of books in the series.

I think it also makes sense to move the Collapse Series option to the same menu. Would you like me to implement that?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3117 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 7/4/2024 **Status:** ✅ Merged **Merged:** 7/9/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `show-subtitles` --- ### 📝 Commits (7) - [`6b6df61`](https://github.com/advplyr/audiobookshelf/commit/6b6df619f56c89318f8907df2f4fca82a68f93f2) Remove tailwind.compiled.css (auto-generated, added by mistake) - [`54f2bb1`](https://github.com/advplyr/audiobookshelf/commit/54f2bb109258976d6f23d7da06055d4a05239449) Add a Show Subtitles option - [`0042604`](https://github.com/advplyr/audiobookshelf/commit/0042604e6de23492ed70151b0d64db4166193ab5) Merge branch 'advplyr:master' into show-subtitles - [`79bd6a2`](https://github.com/advplyr/audiobookshelf/commit/79bd6a25d9de6095a143eafdf288326df4335077) Move Collapse Series option to the tollbar's context menu - [`31c8cb4`](https://github.com/advplyr/audiobookshelf/commit/31c8cb476abb8fcdc23779e1b576881139ab97c6) Make menu item localized where they're not - [`eb5af47`](https://github.com/advplyr/audiobookshelf/commit/eb5af47bbf8927798f72a567b685cdfbf68354f5) Merge branch 'master' into show-subtitles - [`8c4afa1`](https://github.com/advplyr/audiobookshelf/commit/8c4afa186668bc8b5b550bd45039e4ad0f2ae48c) Fix typo ### 📊 Changes **7 files changed** (+117 additions, -4682 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/Appbar.vue` (+2 -2) 📝 `client/components/app/BookShelfToolbar.vue` (+79 -6) 📝 `client/components/cards/LazyBookCard.vue` (+18 -1) ➖ `client/cypress/support/tailwind.compiled.css` (+0 -4672) 📝 `client/cypress/tests/components/cards/LazyBookCard.cy.js` (+11 -1) 📝 `client/store/user.js` (+1 -0) 📝 `client/strings/en-us.json` (+6 -0) </details> ### 📄 Description Fixes #2774. This re-introduces a feature removed from #3037 after some comments from @advplyr : > I don't think we should include the show subtitles in this PR. > It doesn't make sense to show that setting on the regular bookshelf view. It is too tight on mobile for the library page. I think we should use a context menu dropdown if we add more checkboxes to the bookshelf toolbar. Showing series and genres there confused me at first and when it is empty it looks weird. This is a re-write of that feature taking those comments into account. - The Show/Hide Subtitles setting has been moved to the Toolbar's context menu dropdown - The subtitle field shows the subtitle from the metadata, if it exists, or the book's series and sequence if it doesn't. - No genres in this version, but I think series and sequence make sense if there's no subtitle. - This is only shown for books, not for podcasts - For a collpased-series entry, the subtitle shows the number of books in the series. I think it also makes sense to move the Collapse Series option to the same menu. Would you like me to implement that? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:23 +02:00
adam closed this issue 2026-04-25 00:17:23 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?