starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3111] [MERGED] Replace tone with ffmpeg for metadata and cover embedding #3870

New Issue
Closed
opened 2026-04-25 00:17:23 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:23 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3111
Author: @mikiher
Created: 6/29/2024
Status: ✅ Merged
Merged: 7/6/2024
Merged by: @advplyr

Base: master ← Head: tone-replacement

📝 Commits (7)

  • 6fbbc65 Replace tone with ffmpeg for metadata and cover embedding
  • a21b1f3 Make required changes for mp3 embedding
  • 4732ca8 Embed track number
  • ebaec23 Replace tone with ffmpeg in AbMergeManager
  • 1b015be Remove windows restrictions from Tools.vuw
  • 8bdee51 Add unit tests for new ffmpegHelpers functions
  • e6b1acf Remove tone scripts & references, rename tone-object endpoint, remove node-tone dependency, remove TONE_PATH env

📊 Changes

18 files changed (+542 additions, -448 deletions)

View changed files

📝 .devcontainer/Dockerfile (+0 -3)
📝 Dockerfile (+0 -2)
📝 build/debian/DEBIAN/preinst (+1 -15)
📝 client/components/modals/item/tabs/Tools.vue (+3 -12)
📝 client/pages/audiobook/_id/manage.vue (+11 -13)
📝 package-lock.json (+0 -6)
📝 package.json (+0 -1)
📝 readme.md (+1 -1)
📝 server/controllers/LibraryItemController.js (+3 -3)
📝 server/managers/AbMergeManager.js (+46 -40)
📝 server/managers/AudioMetadataManager.js (+29 -43)
📝 server/objects/metadata/AudioMetaTags.js (+15 -11)
📝 server/routers/ApiRouter.js (+1 -1)
📝 server/scanner/MediaProbeData.js (+1 -11)
📝 server/utils/ffmpegHelpers.js (+182 -0)
➖ server/utils/toneHelpers.js (+0 -113)
➖ server/utils/toneProber.js (+0 -173)
➕ test/server/utils/ffmpegHelpers.test.js (+249 -0)

📄 Description

This is an early review for tone -> ffmpeg replacement.

  • No UI changes yet
  • Only m4b embedding has been tested (mp3 embedding will likely only add a couple of ffmpeg flags)

Please let me know if you have any comments up until now, and please don't merge yet.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3111 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 6/29/2024 **Status:** ✅ Merged **Merged:** 7/6/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `tone-replacement` --- ### 📝 Commits (7) - [`6fbbc65`](https://github.com/advplyr/audiobookshelf/commit/6fbbc65edf429e5d4f6ef3d05c8b31a4ea2bf94b) Replace tone with ffmpeg for metadata and cover embedding - [`a21b1f3`](https://github.com/advplyr/audiobookshelf/commit/a21b1f3b168208977fb566a84b76a9f05f8375c1) Make required changes for mp3 embedding - [`4732ca8`](https://github.com/advplyr/audiobookshelf/commit/4732ca811942be63b7dd2e6bafcc45291f5fb75a) Embed track number - [`ebaec23`](https://github.com/advplyr/audiobookshelf/commit/ebaec2364898c3579f79d5d915cdeafbd0709bcb) Replace tone with ffmpeg in AbMergeManager - [`1b015be`](https://github.com/advplyr/audiobookshelf/commit/1b015beba403621e618b28721a7ccf44334cad61) Remove windows restrictions from Tools.vuw - [`8bdee51`](https://github.com/advplyr/audiobookshelf/commit/8bdee51798731b136a46f98a183860f1622781e2) Add unit tests for new ffmpegHelpers functions - [`e6b1acf`](https://github.com/advplyr/audiobookshelf/commit/e6b1acfb449012fea2af57576332910154778a14) Remove tone scripts & references, rename tone-object endpoint, remove node-tone dependency, remove TONE_PATH env ### 📊 Changes **18 files changed** (+542 additions, -448 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+0 -3) 📝 `Dockerfile` (+0 -2) 📝 `build/debian/DEBIAN/preinst` (+1 -15) 📝 `client/components/modals/item/tabs/Tools.vue` (+3 -12) 📝 `client/pages/audiobook/_id/manage.vue` (+11 -13) 📝 `package-lock.json` (+0 -6) 📝 `package.json` (+0 -1) 📝 `readme.md` (+1 -1) 📝 `server/controllers/LibraryItemController.js` (+3 -3) 📝 `server/managers/AbMergeManager.js` (+46 -40) 📝 `server/managers/AudioMetadataManager.js` (+29 -43) 📝 `server/objects/metadata/AudioMetaTags.js` (+15 -11) 📝 `server/routers/ApiRouter.js` (+1 -1) 📝 `server/scanner/MediaProbeData.js` (+1 -11) 📝 `server/utils/ffmpegHelpers.js` (+182 -0) ➖ `server/utils/toneHelpers.js` (+0 -113) ➖ `server/utils/toneProber.js` (+0 -173) ➕ `test/server/utils/ffmpegHelpers.test.js` (+249 -0) </details> ### 📄 Description This is an early review for tone -> ffmpeg replacement. - No UI changes yet - Only m4b embedding has been tested (mp3 embedding will likely only add a couple of ffmpeg flags) Please let me know if you have any comments up until now, and please don't merge yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:23 +02:00
adam closed this issue 2026-04-25 00:17:23 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3870
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?