starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3113] [MERGED] WIP: Add adjustable skip amount #3869

New Issue
Closed
opened 2026-04-25 00:17:23 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:23 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3113
Author: @glorenzen
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/13/2024
Merged by: @advplyr

Base: master ← Head: adjustable-skip-amount

📝 Commits (10+)

  • 039834b Add playback settings string to en-us
  • e5a8430 Add playback settings UI for jump forwards and jump backwards
  • a178596 Remove jump forwards and jump backwards settings
  • 119fe7c Remove jump forwards and jump backwards en-us strings
  • 79cdf5e Update player UI to include player settings button
  • 58b2557 Add label view player settings string
  • 46fa36e Add PlayerSettingsModal component
  • 18a8955 Add player settings modal component to MediaPlayerContainer
  • 809ab80 Handle useChapterTrack changes in PlayerUI
  • bd64b4f Add jump forwards and jump backwards settings to user store

📊 Changes

8 files changed (+283 additions, -18 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+4 -0)
➕ client/components/modals/PlayerSettingsModal.vue (+70 -0)
📝 client/components/player/PlayerPlaybackControls.vue (+27 -7)
📝 client/components/player/PlayerUi.vue (+12 -8)
➕ client/components/ui/SelectInput.vue (+151 -0)
📝 client/players/PlayerHandler.js (+10 -2)
📝 client/store/user.js (+3 -1)
📝 client/strings/en-us.json (+6 -0)

📄 Description

Adding playback settings to allow for adjusting the amount of time that can be skipped forwards and backward, the same as the mobile app.

This is currently a work in progress, and I've only made a few UI changes so far. It's set up similarly to the mobile app, but I'm wondering if it makes sense to use the ToogleBtns component instead of the IconBtn to allow for more options, as is mentioned in #1995 . The only issue with that is that Material Icons only has icons for up to 30s, so I'm not sure how higher than 30s could be displayed in the audio player.

Resolves #1722 , #1995

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3113 **Author:** [@glorenzen](https://github.com/glorenzen) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/13/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `adjustable-skip-amount` --- ### 📝 Commits (10+) - [`039834b`](https://github.com/advplyr/audiobookshelf/commit/039834b6767b0a2e541ef5e04a29c3a4ab955b74) Add playback settings string to en-us - [`e5a8430`](https://github.com/advplyr/audiobookshelf/commit/e5a843076536feade45688e1b67d0a4a99728bb0) Add playback settings UI for jump forwards and jump backwards - [`a178596`](https://github.com/advplyr/audiobookshelf/commit/a17859603630b51e14ad9ac0d6b4ecbfc9340f02) Remove jump forwards and jump backwards settings - [`119fe7c`](https://github.com/advplyr/audiobookshelf/commit/119fe7c2c1697894d54586a2ef24c01f5bc144ed) Remove jump forwards and jump backwards en-us strings - [`79cdf5e`](https://github.com/advplyr/audiobookshelf/commit/79cdf5e6f5af0a2f61a4ecd299af3d1a1a749f20) Update player UI to include player settings button - [`58b2557`](https://github.com/advplyr/audiobookshelf/commit/58b25574043c2bface278dfab21cd83c2c5c4fd9) Add label view player settings string - [`46fa36e`](https://github.com/advplyr/audiobookshelf/commit/46fa36e1fcb25d10a687661a9181b014d5dcd893) Add PlayerSettingsModal component - [`18a8955`](https://github.com/advplyr/audiobookshelf/commit/18a895570eaf65e134c15bf692adf797b06a1dd9) Add player settings modal component to MediaPlayerContainer - [`809ab80`](https://github.com/advplyr/audiobookshelf/commit/809ab8053042450b940319bdd58e40668089d4fd) Handle useChapterTrack changes in PlayerUI - [`bd64b4f`](https://github.com/advplyr/audiobookshelf/commit/bd64b4fe7b031b7888d70480bdaf0f5d3473072a) Add jump forwards and jump backwards settings to user store ### 📊 Changes **8 files changed** (+283 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+4 -0) ➕ `client/components/modals/PlayerSettingsModal.vue` (+70 -0) 📝 `client/components/player/PlayerPlaybackControls.vue` (+27 -7) 📝 `client/components/player/PlayerUi.vue` (+12 -8) ➕ `client/components/ui/SelectInput.vue` (+151 -0) 📝 `client/players/PlayerHandler.js` (+10 -2) 📝 `client/store/user.js` (+3 -1) 📝 `client/strings/en-us.json` (+6 -0) </details> ### 📄 Description Adding playback settings to allow for adjusting the amount of time that can be skipped forwards and backward, the same as the mobile app. This is currently a work in progress, and I've only made a few UI changes so far. It's set up similarly to the mobile app, but I'm wondering if it makes sense to use the ToogleBtns component instead of the IconBtn to allow for more options, as is mentioned in #1995 . The only issue with that is that Material Icons only has icons for up to 30s, so I'm not sure how higher than 30s could be displayed in the audio player. Resolves #1722 , #1995 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:23 +02:00
adam closed this issue 2026-04-25 00:17:23 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?