starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3043] [MERGED] Fix ssrfFilter url #3850

New Issue
Closed
opened 2026-04-25 00:17:18 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:18 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3043
Author: @dbrain
Created: 6/5/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @advplyr

Base: master ← Head: fix-feedurl-copy-paste

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/utils/fileUtils.js (+2 -2)

📄 Description

The recent commit to support disabling the ssrfFilter has broken url loading for non podcasts due to a copy paste error from the podcasts file. This switches the feedUrl back to the original url and makes image loading, and my kid waiting on a new audiobook, happy.

The original issue likely had a few ways to trigger it but in my scenario it was updating an audiobooks metadata and replacing the image, the error in the logs was:

[Server] Unhandled rejection: ReferenceError: feedUrl is not defined, promise: Promise { <rejected> ReferenceError: feedUrl is not defined at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at new Promise (<anonymous>) at Object.downloadFile (/snapshot/audiobookshelf-git/server/utils/fileUtils.js) at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at CoverManager.downloadCoverFromUrl (/snapshot/audiobookshelf-git/server/managers/CoverManager.js) at async ApiRouter.uploadCover (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) at async ApiRouter.updateMedia (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) }

After switching to my branch this error no longer occurs and the image is updated correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3043 **Author:** [@dbrain](https://github.com/dbrain) **Created:** 6/5/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-feedurl-copy-paste` --- ### 📝 Commits (1) - [`0620281`](https://github.com/advplyr/audiobookshelf/commit/06202811b460d5ede99dfdf92ccdcdba6e80d94b) Fix ssrfFilter url ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/fileUtils.js` (+2 -2) </details> ### 📄 Description The recent commit to support disabling the ssrfFilter has broken url loading for non podcasts due to a copy paste error from the podcasts file. This switches the `feedUrl` back to the original `url` and makes image loading, and my kid waiting on a new audiobook, happy. The original issue likely had a few ways to trigger it but in my scenario it was updating an audiobooks metadata and replacing the image, the error in the logs was: ``` [Server] Unhandled rejection: ReferenceError: feedUrl is not defined, promise: Promise { <rejected> ReferenceError: feedUrl is not defined at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at new Promise (<anonymous>) at Object.downloadFile (/snapshot/audiobookshelf-git/server/utils/fileUtils.js) at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at CoverManager.downloadCoverFromUrl (/snapshot/audiobookshelf-git/server/managers/CoverManager.js) at async ApiRouter.uploadCover (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) at async ApiRouter.updateMedia (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) } ``` After switching to my branch this error no longer occurs and the image is updated correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:18 +02:00
adam closed this issue 2026-04-25 00:17:18 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?