starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3009] [MERGED] Time picker cleanup #3839

New Issue
Closed
opened 2026-04-25 00:17:16 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:16 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3009
Author: @nichwall
Created: 5/25/2024
Status: ✅ Merged
Merged: 5/25/2024
Merged by: @advplyr

Base: master ← Head: timePicker_cleanup

📝 Commits (4)

  • 524ed9b Tab removes focus from TimePicker
  • ba6a4f1 Add: TimePicker focusable by tab
  • b9cb54d Onscreen keyboard to appear with TimePicker
  • c58d613 Update client/components/ui/TimePicker.vue

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 client/components/ui/TimePicker.vue (+3 -3)

📄 Description

Fixes https://github.com/advplyr/audiobookshelf/issues/2685

Original behavior was that the TimePicker.vue template was not targetable by a tab. I added a tab target and set the ones place of the seconds to be the default starting point. Currently, users can also tab out of the TimePicker and be focused on two elements, so that is also fixed in this PR.

Original behavior:

https://github.com/advplyr/audiobookshelf/assets/5686638/963ced40-ab9f-46d4-9042-8d1b35d83424

New behavior:

https://github.com/advplyr/audiobookshelf/assets/5686638/b352e903-503e-4715-934c-7ca377c1267d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3009 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 5/25/2024 **Status:** ✅ Merged **Merged:** 5/25/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `timePicker_cleanup` --- ### 📝 Commits (4) - [`524ed9b`](https://github.com/advplyr/audiobookshelf/commit/524ed9b677b65e480c7803873f50c151ed1ff709) Tab removes focus from TimePicker - [`ba6a4f1`](https://github.com/advplyr/audiobookshelf/commit/ba6a4f1224a7af370b57d387eaca30d17c61af94) Add: TimePicker focusable by tab - [`b9cb54d`](https://github.com/advplyr/audiobookshelf/commit/b9cb54db71af3480e299f25819ab83a972906bfa) Onscreen keyboard to appear with `TimePicker` - [`c58d613`](https://github.com/advplyr/audiobookshelf/commit/c58d613949ac5c81c2b86d70b215ebd557102826) Update client/components/ui/TimePicker.vue ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/components/ui/TimePicker.vue` (+3 -3) </details> ### 📄 Description Fixes https://github.com/advplyr/audiobookshelf/issues/2685 Original behavior was that the TimePicker.vue template was not targetable by a tab. I added a tab target and set the ones place of the seconds to be the default starting point. Currently, users can also tab out of the TimePicker and be focused on two elements, so that is also fixed in this PR. Original behavior: https://github.com/advplyr/audiobookshelf/assets/5686638/963ced40-ab9f-46d4-9042-8d1b35d83424 New behavior: https://github.com/advplyr/audiobookshelf/assets/5686638/b352e903-503e-4715-934c-7ca377c1267d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:16 +02:00
adam closed this issue 2026-04-25 00:17:16 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?