starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3010] [MERGED] Ereader settings update #3838

New Issue
Closed
opened 2026-04-25 00:17:16 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:16 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3010
Author: @nichwall
Created: 5/25/2024
Status: ✅ Merged
Merged: 5/25/2024
Merged by: @advplyr

Base: master ← Head: ereader_settings_update

📝 Commits (4)

  • 4e40dbc Add: user column to ereaders
  • aaaa314 Add: information to whitelist email
  • 2f72300 Update email page to only load users when needed
  • 6fad452 Map translations

📊 Changes

28 files changed (+111 additions, -32 deletions)

View changed files

📝 client/components/modals/emails/EReaderDeviceModal.vue (+11 -23)
📝 client/pages/config/email.vue (+43 -4)
📝 client/strings/bg.json (+2 -0)
📝 client/strings/bn.json (+2 -0)
📝 client/strings/cs.json (+2 -0)
📝 client/strings/da.json (+2 -0)
📝 client/strings/de.json (+2 -0)
📝 client/strings/en-us.json (+2 -0)
📝 client/strings/es.json (+4 -2)
📝 client/strings/et.json (+2 -0)
📝 client/strings/fr.json (+3 -1)
📝 client/strings/gu.json (+2 -0)
📝 client/strings/he.json (+2 -0)
📝 client/strings/hi.json (+2 -0)
📝 client/strings/hr.json (+2 -0)
📝 client/strings/hu.json (+2 -0)
📝 client/strings/it.json (+2 -0)
📝 client/strings/lt.json (+2 -0)
📝 client/strings/nl.json (+2 -0)
📝 client/strings/no.json (+2 -0)

...and 8 more files

📄 Description

Fixes https://github.com/advplyr/audiobookshelf/issues/2990 and https://github.com/advplyr/audiobookshelf/issues/2991.

A comma separated list is generated if specific users have been given access to an e-reader. I thought about making this name the first two users and then "and N others", but decided against that for now.

I am not sure how to improve mapping user IDs to names, but it's something.

implemtation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3010 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 5/25/2024 **Status:** ✅ Merged **Merged:** 5/25/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ereader_settings_update` --- ### 📝 Commits (4) - [`4e40dbc`](https://github.com/advplyr/audiobookshelf/commit/4e40dbc3a55ba696347b7fd77a02fb5d449722e1) Add: user column to ereaders - [`aaaa314`](https://github.com/advplyr/audiobookshelf/commit/aaaa31476119536563e19a4790ac782e0a3a2efd) Add: information to whitelist email - [`2f72300`](https://github.com/advplyr/audiobookshelf/commit/2f723006361df13320b7021615bd4a2f020eb2fd) Update email page to only load users when needed - [`6fad452`](https://github.com/advplyr/audiobookshelf/commit/6fad4521d43348c2263a9d9d53548512a0b653b3) Map translations ### 📊 Changes **28 files changed** (+111 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/emails/EReaderDeviceModal.vue` (+11 -23) 📝 `client/pages/config/email.vue` (+43 -4) 📝 `client/strings/bg.json` (+2 -0) 📝 `client/strings/bn.json` (+2 -0) 📝 `client/strings/cs.json` (+2 -0) 📝 `client/strings/da.json` (+2 -0) 📝 `client/strings/de.json` (+2 -0) 📝 `client/strings/en-us.json` (+2 -0) 📝 `client/strings/es.json` (+4 -2) 📝 `client/strings/et.json` (+2 -0) 📝 `client/strings/fr.json` (+3 -1) 📝 `client/strings/gu.json` (+2 -0) 📝 `client/strings/he.json` (+2 -0) 📝 `client/strings/hi.json` (+2 -0) 📝 `client/strings/hr.json` (+2 -0) 📝 `client/strings/hu.json` (+2 -0) 📝 `client/strings/it.json` (+2 -0) 📝 `client/strings/lt.json` (+2 -0) 📝 `client/strings/nl.json` (+2 -0) 📝 `client/strings/no.json` (+2 -0) _...and 8 more files_ </details> ### 📄 Description Fixes https://github.com/advplyr/audiobookshelf/issues/2990 and https://github.com/advplyr/audiobookshelf/issues/2991. A comma separated list is generated if specific users have been given access to an e-reader. I thought about making this name the first two users and then "and N others", but decided against that for now. I am not sure how to improve mapping user IDs to names, but it's something. ![implemtation](https://github.com/advplyr/audiobookshelf/assets/5686638/6d84fa5f-929d-4865-96d6-2cab108ccaf2) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:16 +02:00
adam closed this issue 2026-04-25 00:17:16 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?