starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2954] [MERGED] Fix series and collapsed series progress to be consistent and show average of book series progress #3829

New Issue
Closed
opened 2026-04-25 00:17:13 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:13 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2954
Author: @mikiher
Created: 5/9/2024
Status: ✅ Merged
Merged: 5/12/2024
Merged by: @advplyr

Base: master ← Head: series-progress-fixes

📝 Commits (9)

  • a668921 Prettier-only formatting changes
  • c674042 Add libraryItemIds to collapsedSeries objects
  • e384527 Simplify progress bar and show correct collapsed series progress
  • 057bc1a Fix series progress to show sum of series book progresses
  • 05c1ced Update LazyBookCard progress calculation to handle finished items
  • 8cc3bfa Add test identifiers to LazyBookCard
  • b244cc8 Add LazyBookCard tests
  • 911d729 Removed incorrect stylesheet reference
  • 60fc4e2 Cleanup inconsistencies with ExplicitIndicator component by removing prop

📊 Changes

16 files changed (+517 additions, -182 deletions)

View changed files

📝 client/components/app/MediaPlayerContainer.vue (+7 -5)
📝 client/components/cards/BookMatchCard.vue (+1 -1)
📝 client/components/cards/LazyBookCard.vue (+45 -38)
📝 client/components/cards/LazySeriesCard.vue (+7 -3)
📝 client/components/tables/podcast/DownloadQueueTable.vue (+1 -1)
📝 client/components/widgets/ExplicitIndicator.vue (+2 -4)
➕ client/cypress/fixtures/images/cover1.jpg (+0 -0)
➕ client/cypress/fixtures/images/cover2.jpg (+0 -0)
📝 client/cypress/support/component-index.html (+0 -1)
➕ client/cypress/tests/components/cards/LazyBookCard.cy.js (+342 -0)
📝 client/cypress/tests/components/cards/LazySeriesCard.cy.js (+6 -5)
📝 client/pages/item/_id/index.vue (+2 -2)
📝 client/pages/library/_library/podcast/download-queue.vue (+2 -2)
📝 client/pages/library/_library/podcast/latest.vue (+2 -2)
📝 client/pages/library/_library/podcast/search.vue (+1 -1)
📝 server/utils/queries/libraryItemsBookFilters.js (+99 -117)

📄 Description

This fixes #2921.

In a nutshell, the changes are:

  • Correct series and collapsed series progress bars to show the same
    • The series card in the Series page and collapsed series book card display the same progress.
    • The progress displayed is now the average of the series books progress (i.e. the sum of all the series individual book progresses, divided by the number of books in the series)
  • Added libraryItemIds to collapsedSeries objects return from the server
    • This fixes the bug in seriesIsFinished in LazyBookCard, which currently always returns true
  • Simplified progress bar logic in LazyBookCard

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2954 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 5/9/2024 **Status:** ✅ Merged **Merged:** 5/12/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `series-progress-fixes` --- ### 📝 Commits (9) - [`a668921`](https://github.com/advplyr/audiobookshelf/commit/a668921e29f0948b170b806053702bc94450695e) Prettier-only formatting changes - [`c674042`](https://github.com/advplyr/audiobookshelf/commit/c6740423198c6d845b356f270e84fd9f828ddd81) Add libraryItemIds to collapsedSeries objects - [`e384527`](https://github.com/advplyr/audiobookshelf/commit/e384527b672f8ce5d1c31b7f95488c75baadf99d) Simplify progress bar and show correct collapsed series progress - [`057bc1a`](https://github.com/advplyr/audiobookshelf/commit/057bc1a0c0bd51a4f1d5f0db0846633d3c689184) Fix series progress to show sum of series book progresses - [`05c1ced`](https://github.com/advplyr/audiobookshelf/commit/05c1ced65c79414c7ac2c0c1cd64a044ef5063de) Update LazyBookCard progress calculation to handle finished items - [`8cc3bfa`](https://github.com/advplyr/audiobookshelf/commit/8cc3bfa95e6ea334363697f5107908d8909630e9) Add test identifiers to LazyBookCard - [`b244cc8`](https://github.com/advplyr/audiobookshelf/commit/b244cc8d41e76a957a53fbe19471a05ddce96edc) Add LazyBookCard tests - [`911d729`](https://github.com/advplyr/audiobookshelf/commit/911d72971eedb7e31539636ce7178e6cdbce6d0a) Removed incorrect stylesheet reference - [`60fc4e2`](https://github.com/advplyr/audiobookshelf/commit/60fc4e20e6825944388e97a38b6c81cc57e0b15a) Cleanup inconsistencies with ExplicitIndicator component by removing prop ### 📊 Changes **16 files changed** (+517 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/MediaPlayerContainer.vue` (+7 -5) 📝 `client/components/cards/BookMatchCard.vue` (+1 -1) 📝 `client/components/cards/LazyBookCard.vue` (+45 -38) 📝 `client/components/cards/LazySeriesCard.vue` (+7 -3) 📝 `client/components/tables/podcast/DownloadQueueTable.vue` (+1 -1) 📝 `client/components/widgets/ExplicitIndicator.vue` (+2 -4) ➕ `client/cypress/fixtures/images/cover1.jpg` (+0 -0) ➕ `client/cypress/fixtures/images/cover2.jpg` (+0 -0) 📝 `client/cypress/support/component-index.html` (+0 -1) ➕ `client/cypress/tests/components/cards/LazyBookCard.cy.js` (+342 -0) 📝 `client/cypress/tests/components/cards/LazySeriesCard.cy.js` (+6 -5) 📝 `client/pages/item/_id/index.vue` (+2 -2) 📝 `client/pages/library/_library/podcast/download-queue.vue` (+2 -2) 📝 `client/pages/library/_library/podcast/latest.vue` (+2 -2) 📝 `client/pages/library/_library/podcast/search.vue` (+1 -1) 📝 `server/utils/queries/libraryItemsBookFilters.js` (+99 -117) </details> ### 📄 Description This fixes #2921. In a nutshell, the changes are: - Correct series and collapsed series progress bars to show the same - The series card in the Series page and collapsed series book card display the same progress. - The progress displayed is now the average of the series books progress (i.e. the sum of all the series individual book progresses, divided by the number of books in the series) - Added libraryItemIds to collapsedSeries objects return from the server - This fixes the bug in `seriesIsFinished` in LazyBookCard, which currently always returns true - Simplified progress bar logic in LazyBookCard --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:13 +02:00
adam closed this issue 2026-04-25 00:17:13 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?