starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2891] [MERGED] Tweaks to custom metadata provider schema #3820

New Issue
Closed
opened 2026-04-25 00:17:11 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:11 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2891
Author: @ahobsonsayers
Created: 4/30/2024
Status: ✅ Merged
Merged: 4/30/2024
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (1)

  • d488b17 Update custom metadata provider schema

📊 Changes

1 file changed (+31 additions, -26 deletions)

View changed files

📝 custom-metadata-provider-specification.yaml (+31 -26)

📄 Description

When developing my custom metadata provider, I noticed a couple of issues with the provider schema that I thought I would fix. I also did a bit of minor tidy up (I hope this is ok, If not let me know and I will revert!)

Schema changes:

  • duration type should be an integer not a number
  • I have split out SeriesMetadata to its own component, as this will generate its own type for those who use generators with the schema, instead of nested anonymous objects.
  • series under SeriesMetadata being required was specified in the incorrect way using required: <bool> instead of required: <property array>
  • sequence under SeriesMetadata should not be a number, it should be a string to allow for sequences like 0.5, 1-3 and 1,3,5

Let me know if there is any changes you would like me to make!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2891 **Author:** [@ahobsonsayers](https://github.com/ahobsonsayers) **Created:** 4/30/2024 **Status:** ✅ Merged **Merged:** 4/30/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d488b17`](https://github.com/advplyr/audiobookshelf/commit/d488b17869c0fc320581410e8cc05d1c82c60fa7) Update custom metadata provider schema ### 📊 Changes **1 file changed** (+31 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `custom-metadata-provider-specification.yaml` (+31 -26) </details> ### 📄 Description When developing my [custom metadata provider](https://github.com/ahobsonsayers/abs-tract), I noticed a couple of issues with the provider schema that I thought I would fix. I also did a bit of minor tidy up (I hope this is ok, If not let me know and I will revert!) Schema changes: - `duration` type should be an integer not a number - I have split out `SeriesMetadata` to its own component, as this will generate its own type for those who use generators with the schema, instead of nested anonymous objects. - `series` under SeriesMetadata being required was specified in the incorrect way using `required: <bool>` instead of `required: <property array>` - `sequence` under SeriesMetadata should not be a number, it should be a string to allow for sequences like `0.5`, `1-3` and `1,3,5` Let me know if there is any changes you would like me to make! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:11 +02:00
adam closed this issue 2026-04-25 00:17:11 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3820
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?