starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2820] [MERGED] Add option to set Signing Algorithm for OpenID Authentification #3812

New Issue
Closed
opened 2026-04-25 00:17:09 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:09 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2820
Author: @apocer
Created: 4/3/2024
Status: ✅ Merged
Merged: 4/21/2024
Merged by: @advplyr

Base: master ← Head: openid_signing_algorithm

📝 Commits (5)

  • 6c9a811 Add ui and settings for OpenID Signing Algorithm
  • 304d0f6 id_token_signed_respo... should be in new Client
  • f75f0b8 show dropdown if issuer has list of algorithms
  • af856ce Merge branch 'master' into openid_signing_algorithm
  • a8af6db Format update of authentication page for supported algorithms

📊 Changes

3 files changed (+36 additions, -4 deletions)

View changed files

📝 client/pages/config/authentication.vue (+25 -0)
📝 server/Auth.js (+4 -2)
📝 server/objects/settings/ServerSettings.js (+7 -2)

📄 Description

Currently the ID Token returned from a OIDC Provider needs to be signed using the RS256 algorithm. This is quite restrictive. I had trouble using my Let's Encrypt certificates for signing the ID token with Authentik, because Let's Encrypt uses ES256.

This PR adds a setting for the signing algorithm, which is used to configure the Passport OpenID client.

What changed:

  • Added authOpenIDTokenSigningAlgorithm to ServerSettings with RS256 being the default
  • Added Signing Algorithm Field in the authentication settings of the WebUI
  • The Signing Algorithm is also fetched by the Auto-populate button

grafik

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2820 **Author:** [@apocer](https://github.com/apocer) **Created:** 4/3/2024 **Status:** ✅ Merged **Merged:** 4/21/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `openid_signing_algorithm` --- ### 📝 Commits (5) - [`6c9a811`](https://github.com/advplyr/audiobookshelf/commit/6c9a81147249f195709c951c9203a99d851c6663) Add ui and settings for OpenID Signing Algorithm - [`304d0f6`](https://github.com/advplyr/audiobookshelf/commit/304d0f6d43684b43f1db169856ba75b253267d7f) id_token_signed_respo... should be in new Client - [`f75f0b8`](https://github.com/advplyr/audiobookshelf/commit/f75f0b8cc8e681a7491038c4c9f83e86e69f0e6b) show dropdown if issuer has list of algorithms - [`af856ce`](https://github.com/advplyr/audiobookshelf/commit/af856ce1ec00e7974aaed8b31b16edda5c87e932) Merge branch 'master' into openid_signing_algorithm - [`a8af6db`](https://github.com/advplyr/audiobookshelf/commit/a8af6db3d608d64711e7e600bf21a748025fde9b) Format update of authentication page for supported algorithms ### 📊 Changes **3 files changed** (+36 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/config/authentication.vue` (+25 -0) 📝 `server/Auth.js` (+4 -2) 📝 `server/objects/settings/ServerSettings.js` (+7 -2) </details> ### 📄 Description Currently the ID Token returned from a OIDC Provider needs to be signed using the `RS256` algorithm. This is quite restrictive. I had trouble using my Let's Encrypt certificates for signing the ID token with Authentik, because Let's Encrypt uses `ES256`. **This PR adds a setting for the signing algorithm, which is used to configure the Passport OpenID client.** What changed: - Added `authOpenIDTokenSigningAlgorithm` to `ServerSettings` with `RS256` being the default - Added `Signing Algorithm` Field in the authentication settings of the WebUI - The `Signing Algorithm` is also fetched by the `Auto-populate` button ![grafik](https://github.com/advplyr/audiobookshelf/assets/10885533/b5f8b691-8644-4cfd-b43d-5b102d733d50) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:09 +02:00
adam closed this issue 2026-04-25 00:17:09 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?